-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CADC-8776 update doi service int-test #9
Open
jburke-cadc
wants to merge
4
commits into
opencadc:main
Choose a base branch
from
jburke-cadc:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c4b176b
CADC-8776 code review rework
jburke-cadc 0a430d1
CADC-8776 update doi.properties processing
jburke-cadc ce2fdaa
CADC-8776 replace individual CRUD tests with a single DOI lifecycle test
jburke-cadc c68b76e
CADC-8776 remove old CRUD int-tests
jburke-cadc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
# intTest.properties expects the following entries: | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't this file be in |
||
# The resourceID of the doi service | ||
doiResourceID = ivo://opencadc.org/doi | ||
|
||
# The VOSURI of the DOI parent folder in the VOSpace service. | ||
vospaceParentUri = vos://opencadc.org~vospace/<DOI parent path> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,13 @@ | ||
# doi service integration tests | ||
|
||
The integration tests run against a local doi instance defined by the `ivo://opencadc.org/doi` resourceID, | ||
and a vault service defined by the `ivo://opencadc.org/vault` resourceID'. | ||
The integration tests can run against a local `doi` service, and either a local or remove VOSpace service. | ||
|
||
The integration tests expect the following entries in `intTest.properties` in the root of the doi module. | ||
`doiResoruceID` is the resourceID of the doi service. | ||
`vospaceParentUri` is the VOSURI of the DOI parent folder in the VOSpace service. | ||
|
||
Client test certificates in the `$A/test-certificates/` directory are used to authenticate to the doi service. | ||
The following certificates are expected. | ||
- `doiadmin.pem` owns and has full access to a test DOI. | ||
- `doi-auth.pem` has read-write access to a test DOI. | ||
- `doi-noauth.pem` has read-only access to a test DOI. | ||
|
||
The integration tests expect the following entries in `doi.properties`. | ||
|
||
`ca.nrc.cadc.doi.test.randomName = true` to create random DOI names for testing. | ||
|
||
`ca.nrc.cadc.doi.test.groupUri = {group URI}` to specify the group URI that will have read/write permissions to a test DOI. | ||
The `doi-auth.pem` user is a member of this group, giving this user read/write access to a test DOI. | ||
The `doi-noauth.pem` user is not a member of this group, giving this user read-only access to a test DOI. | ||
- `doi-admin.pem` owns and has full permissions to a test DOI. | ||
- `doi-auth.pem` has read-write permissions to a test DOI. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How? A group is required for that I assume. |
||
- `doi-noauth.pem` has read-only permissions to a test DOI. |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really necessary? Can just the prefix and different test directory be enough? Under what circumstances would int testing interfere with production and what would be the consequences?
If you can get rid of this then you can remove traces of test code in the service code as well.