Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: extend misconfiguration scanners rfc #1114

Merged
merged 5 commits into from
Jan 24, 2024
Merged

Conversation

ramizpolic
Copy link
Member

Description

This PR includes an RFC that aims to:

  • extends necessary logic to enable generic misconfiguration scanning capabilities, in order to
  • provide a simple way to migrate CIS Docker Benchmark scanner from KubeClarity

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[x] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@ramizpolic ramizpolic added scanners Issues related to adding new scanners rfc labels Jan 22, 2024
@ramizpolic ramizpolic self-assigned this Jan 22, 2024
@ramizpolic ramizpolic requested a review from a team as a code owner January 22, 2024 15:54

This comment has been minimized.

This comment has been minimized.

@ramizpolic ramizpolic force-pushed the rfc/cis-docker-benchmark branch 3 times, most recently from ea1a457 to 700ed2e Compare January 22, 2024 16:42

This comment has been minimized.

paralta
paralta previously approved these changes Jan 23, 2024
Copy link
Contributor

@paralta paralta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

rfc/extend-misconfiguration-scanners.md Outdated Show resolved Hide resolved
Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny remark, otherwise looks good to me.

Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1114-58d5197f9365cb05543fdf8af7f36d015bc380d9
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1114-58d5197f9365cb05543fdf8af7f36d015bc380d9
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1114-58d5197f9365cb05543fdf8af7f36d015bc380d9
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1114-58d5197f9365cb05543fdf8af7f36d015bc380d9
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1114-58d5197f9365cb05543fdf8af7f36d015bc380d9

Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@ramizpolic ramizpolic added this pull request to the merge queue Jan 24, 2024
Merged via the queue into main with commit 125d90a Jan 24, 2024
33 checks passed
@ramizpolic ramizpolic deleted the rfc/cis-docker-benchmark branch January 24, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfc scanners Issues related to adding new scanners
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants