Skip to content
This repository has been archived by the owner on Oct 14, 2024. It is now read-only.

docs: compliance scanning capabilities proposal #987

Closed
wants to merge 1 commit into from
Closed

docs: compliance scanning capabilities proposal #987

wants to merge 1 commit into from

Conversation

ramizpolic
Copy link
Member

@ramizpolic ramizpolic commented Nov 30, 2023 •
edited
Loading

Description

This PR includes an RFC that aims to:

  • add necessary logic to enable generic compliance scanning capabilities, in order to
  • provide a simple way to migrate CIS Docker Benchmark scanner from KubeClarity

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[x] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@ramizpolic ramizpolic added the rfc label Nov 30, 2023
@ramizpolic ramizpolic requested a review from a team as a code owner November 30, 2023 04:55
@ramizpolic ramizpolic marked this pull request as draft December 1, 2023 09:30
@ramizpolic ramizpolic marked this pull request as ready for review December 6, 2023 03:27
@ramizpolic ramizpolic added enhancement New feature or request scanners Issues related to adding new scanners component:ui-backend component:ui Issues related to UI/Frontend labels Dec 6, 2023
akijakya
akijakya previously approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@akijakya akijakya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

gallotamas
gallotamas previously approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@gallotamas gallotamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ramizpolic ramizpolic changed the title docs: add rfc for compliance scanning docs(rfc): add compliance scanning capabilities Dec 6, 2023
@ramizpolic ramizpolic changed the title docs(rfc): add compliance scanning capabilities docs: compliance scanning capabilities proposal Dec 6, 2023
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@ramizpolic ramizpolic mentioned this pull request Dec 6, 2023
Closed
4 tasks
@openclarity openclarity deleted a comment from github-actions bot Dec 6, 2023
@openclarity openclarity deleted a comment from github-actions bot Dec 6, 2023
@openclarity openclarity deleted a comment from github-actions bot Dec 6, 2023
@openclarity openclarity deleted a comment from github-actions bot Dec 6, 2023
@openclarity openclarity deleted a comment from github-actions bot Dec 6, 2023
@ramizpolic ramizpolic added the component:api Issues related to API label Dec 6, 2023
@ramizpolic ramizpolic requested a review from a team December 8, 2023 10:38
@ramizpolic
docs(rfc): add compliance scanning capabilities
23c8ff1 
Signed-off-by: Ramiz Polic <ramiz.polic@hotmail.com>
@github-actions GitHub Actions
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr987-f012a11a969a79238ac6d230e1f58fcc846b16b3
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr987-f012a11a969a79238ac6d230e1f58fcc846b16b3
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr987-f012a11a969a79238ac6d230e1f58fcc846b16b3
  • ghcr.io/openclarity/vmclarity-ui-dev:pr987-f012a11a969a79238ac6d230e1f58fcc846b16b3
  • ghcr.io/openclarity/vmclarity-cli-dev:pr987-f012a11a969a79238ac6d230e1f58fcc846b16b3

@ramizpolic ramizpolic self-assigned this Dec 16, 2023
paralta
paralta approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@paralta paralta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ramizpolic ramizpolic removed scanners Issues related to adding new scanners component:api Issues related to API component:ui-backend component:ui Issues related to UI/Frontend labels Jan 19, 2024
@ramizpolic
Copy link
Member Author

Closing in favour of #1114

@ramizpolic ramizpolic closed this Jan 22, 2024
@ramizpolic ramizpolic deleted the rfc/compliance branch January 22, 2024 15:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamtagscherer adamtagscherer adamtagscherer approved these changes

@paralta paralta paralta approved these changes

@lgecse lgecse lgecse approved these changes

@gallotamas gallotamas gallotamas left review comments

@akijakya akijakya akijakya left review comments

Assignees

@ramizpolic ramizpolic

Labels
enhancement New feature or request rfc
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ramizpolic @adamtagscherer @gallotamas @akijakya @paralta @lgecse