Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: subst spaces with commas in GO_BUILD_TAGS #1394

Merged
merged 1 commit into from
Mar 4, 2024
Merged

fix: subst spaces with commas in GO_BUILD_TAGS #1394

merged 1 commit into from
Mar 4, 2024

Conversation

akijakya
Copy link
Contributor

@akijakya akijakya commented Mar 3, 2024

Description

Create a comma-separated list instead of a space-separated list from GO_BUILD_TAGS in the Makefile. The previous solution worked for go-related make targets (build, test, vet stc.) but was not sufficient for the make docker* targets.

Type of Change

[X] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@akijakya akijakya added the bug Something isn't working label Mar 3, 2024
@akijakya akijakya self-assigned this Mar 3, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@akijakya akijakya marked this pull request as ready for review March 4, 2024 08:12
@akijakya akijakya requested a review from a team as a code owner March 4, 2024 08:12
chrisgacsal
chrisgacsal requested changes Mar 4, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@akijakya
fix: subst spaces with commas in GO_BUILD_TAGS
8afeabe 
Signed-off-by: András Jáky <ajaky@cisco.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1394-6dcb7e880a2ecd07f74252c686318f24795b2768
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1394-6dcb7e880a2ecd07f74252c686318f24795b2768
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1394-6dcb7e880a2ecd07f74252c686318f24795b2768
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1394-6dcb7e880a2ecd07f74252c686318f24795b2768
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1394-6dcb7e880a2ecd07f74252c686318f24795b2768
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1394-6dcb7e880a2ecd07f74252c686318f24795b2768

@akijakya akijakya added this pull request to the merge queue Mar 4, 2024
Merged via the queue into main with commit 574ac2a Mar 4, 2024
34 checks passed
@akijakya akijakya deleted the fix-go-build-tags branch March 4, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgacsal chrisgacsal chrisgacsal approved these changes

Assignees

@akijakya akijakya

Labels
bug Something isn't working
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akijakya @chrisgacsal