feat: Separate asset discovery from scanning #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
separate_discovery_new
branch
from
1f9d119
to
e857900
Compare
akpsgit
reviewed
Jun 29, 2023
akpsgit
reviewed
Jun 29, 2023
akpsgit
reviewed
Jun 29, 2023
akpsgit
reviewed
Jun 29, 2023
ghost
mentioned this pull request
7 tasks
akpsgit
reviewed
Jun 29, 2023
akpsgit
reviewed
Jun 29, 2023
akpsgit
reviewed
Jun 29, 2023
akpsgit
reviewed
Jun 29, 2023
fishkerez
reviewed
Jul 3, 2023
ghost
force-pushed
the
separate_discovery_new
branch
2 times, most recently
from
3fb38aa
to
447aa43
Compare
akpsgit
reviewed
Jul 4, 2023
akpsgit
reviewed
Jul 4, 2023
ghost
force-pushed
the
separate_discovery_new
branch
from
447aa43
to
2fae375
Compare
This commit removes the concept of scopes and instead replaces it with periodic discovery of assets. These assets will be created in the system and a ScanConfig can be configured with an ODATA $filter expression to choose the assets to scan. This increases user visibility into the assets available to scan by VMClarity, it also gives the system an opportunity to estimate how many items a ScanConfig might scan based on a particular query. It also opens the door for additional features such as the ability to scan a specific asset which has never been scanned before. Assets are tracked with lastSeen timestamp which indicates when it was last seen by discovery. When they are not found in a discovery round they are marked as terminated. Terminated assets will not be included in scans even if they match the $filter configured by the user for the scan.
ghost
force-pushed
the
separate_discovery_new
branch
from
2fae375
to
66a45a9
Compare
ghost
mentioned this pull request
ghost
mentioned this pull request
akpsgit
reviewed
Jul 6, 2023
akpsgit
approved these changes
Jul 9, 2023
fishkerez
reviewed
Jul 10, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit removes the concept of scopes and instead replaces it with periodic discovery of assets. These assets will be created in the system and a ScanConfig can be configured with an ODATA $filter expression to choose the assets to scan.
This increases user visibility into the assets available to scan by VMClarity, it also gives the system an opportunity to estimate how many items a ScanConfig might scan based on a particular query.
It also opens the door for additional features such as the ability to scan a specific asset which has never been scanned before.
Assets are tracked with lastSeen timestamp which indicates when it was last seen by discovery. When they are not found in a discovery round they are marked as terminated. Terminated assets will not be included in scans even if they match the $filter configured by the user for the scan.
Type of Change
[ ] Bug Fix
[X] New Feature
[ ] Breaking Change
[X] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist