Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update scope in scan configuration examples #474

Merged
merged 1 commit into from
Jul 18, 2023
Merged

docs: Update scope in scan configuration examples #474

merged 1 commit into from
Jul 18, 2023

Conversation

paralta
Copy link
Contributor

@paralta paralta commented Jul 17, 2023

Description

#457

Adjust scanConfig examples by updating the scope object to reflect the changes introduced by #438

Tested in AWS with empty scope, with tag scope and with region+vpc+secgroup scope.

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[x] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@paralta paralta requested a review from a team as a code owner July 17, 2023 14:49
@paralta paralta self-assigned this Jul 17, 2023
@paralta paralta added the documentation Improvements or additions to documentation label Jul 17, 2023
@paralta paralta added this to the v0.6.0 milestone Jul 17, 2023
@paralta paralta linked an issue Jul 17, 2023 that may be closed by this pull request
Adjust scanConfig examples all over the project #457
Closed
@paralta paralta added this pull request to the merge queue Jul 18, 2023
Merged via the queue into main with commit 0964ba9 Jul 18, 2023
5 checks passed
@paralta paralta deleted the issue457-change-scope branch July 18, 2023 15:35
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fishkerez fishkerez fishkerez approved these changes

Assignees

@paralta paralta

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

Adjust scanConfig examples all over the project
2 participants
@paralta @fishkerez