Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: yara support #638

Merged
merged 48 commits into from
Sep 19, 2023
Merged

feat: yara support #638

merged 48 commits into from
Sep 19, 2023

Conversation

pbalogh-sa
Copy link
Member

@pbalogh-sa pbalogh-sa commented Sep 6, 2023 •
edited

Description

This PR adds Yara support for VMClarity.
closes: #576
Merge after yara-rule-server was released: openclarity/yara-rule-server#1

Type of Change

[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@pbalogh-sa pbalogh-sa marked this pull request as ready for review September 6, 2023 11:28
@pbalogh-sa pbalogh-sa requested a review from a team as a code owner September 6, 2023 11:28
FrimIdan
FrimIdan reviewed Sep 6, 2023
View reviewed changes
pkg/shared/families/malware/yara/yara.go Outdated Show resolved Hide resolved
pkg/shared/families/malware/yara/yara.go Outdated Show resolved Hide resolved
pkg/shared/families/malware/yara/yara.go Outdated Show resolved Hide resolved
pkg/shared/families/malware/yara/yara.go Outdated Show resolved Hide resolved
Tehsmash
Tehsmash requested changes Sep 6, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
installation/aws/VmClarity.cfn Outdated Show resolved Hide resolved
installation/azure/vmclarity-UI.json Outdated Show resolved Hide resolved
pkg/shared/families/malware/yara/util/yara_util.go Outdated Show resolved Hide resolved
pkg/shared/families/malware/yara/util/yara_util.go Outdated Show resolved Hide resolved
pkg/shared/families/malware/yara/util/yara_util.go Outdated Show resolved Hide resolved
pkg/shared/families/malware/yara/util/yara_util_test.go Outdated Show resolved Hide resolved
pkg/shared/families/malware/yara/yara.go Outdated Show resolved Hide resolved
pkg/shared/families/malware/yara/yara.go Outdated Show resolved Hide resolved
api/openapi.yaml Show resolved Hide resolved
@pbalogh-sa pbalogh-sa changed the title Yara support feat: yara support Sep 6, 2023
Tehsmash
Tehsmash requested changes Sep 13, 2023
View reviewed changes
pkg/orchestrator/assetscanprocessor/malware.go Show resolved Hide resolved
installation/azure/vmclarity-install.sh Outdated Show resolved Hide resolved
pkg/shared/utils/utils.go Show resolved Hide resolved
ui/src/layout/Findings/Malware/MalwareTable.js Show resolved Hide resolved
akpsgit
akpsgit previously requested changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@akpsgit akpsgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I request changes

@akpsgit akpsgit dismissed their stale review September 13, 2023 13:48

it wasn't good

fishkerez
fishkerez previously approved these changes Sep 14, 2023
View reviewed changes
Tehsmash
Tehsmash requested changes Sep 14, 2023
View reviewed changes
pkg/shared/findingkey/malware.go Outdated Show resolved Hide resolved
pkg/shared/findingkey/malware.go Outdated Show resolved Hide resolved
chrisgacsal
chrisgacsal requested changes Sep 14, 2023
View reviewed changes
installation/docker/yara-rule-server.yaml Outdated Show resolved Hide resolved
pkg/shared/families/malware/yara/config/config.go Show resolved Hide resolved
pkg/shared/findingkey/malware.go Outdated Show resolved Hide resolved
@pbalogh-sa pbalogh-sa requested review from Tehsmash, akpsgit and chrisgacsal and removed request for akpsgit September 14, 2023 15:02
@pbalogh-sa pbalogh-sa added this pull request to the merge queue Sep 19, 2023
Merged via the queue into main with commit 32adb9d Sep 19, 2023
16 checks passed
@pbalogh-sa pbalogh-sa deleted the yara-support branch September 19, 2023 09:54
@lgecse lgecse mentioned this pull request Oct 2, 2023
Closed
1 task
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
Merged
7 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No scope found in pull request title "feat: yara support". Scope must match one of: general, api, cli, containerruntimediscovery, core, orchestrator, plugin, provider, scanner, ui, uibackend, utils, workflow, aws, azure, docker, gcp, helm, k8s, ci, deps, e2e, testenv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrimIdan FrimIdan FrimIdan left review comments

@Tehsmash Tehsmash Tehsmash approved these changes

@chrisgacsal chrisgacsal chrisgacsal approved these changes

@akpsgit akpsgit akpsgit left review comments

@fishkerez fishkerez fishkerez left review comments

Assignees
No one assigned
Labels
None yet
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

YARA Malware scanner job
6 participants
@pbalogh-sa @Tehsmash @chrisgacsal @akpsgit @FrimIdan @fishkerez