Download rules and unarchive them #1

pbalogh-sa · 2023-08-23T08:03:50Z

No description provided.

.github/PULL_REQUEST_TEMPLATE.md

.github/ISSUE_TEMPLATE/BUG_REPORT.md

.github/stale.yml

.github/workflows/ci.yml

.yara-rule-server-example

cmd/root.go

pkg/config/config.go

Tehsmash · 2023-08-29T13:05:47Z

We should add a task to add support for a healthz server to make sure that we can add a healthcheck when running this in kubernetes/docker compose.

cmd/root.go

pkg/config/config.go

pkg/fileserver/fileserver.go

pkg/rules/compile.go

pkg/rules/download.go

FrimIdan · 2023-08-30T04:55:45Z

@pbalogh-sa please separate all the .github changes (basically all the code that is not related to the download & archive logic) to a separate PR so it will be pushed first.

pbalogh-sa · 2023-08-30T14:55:12Z

@FrimIdan I've created a separated PR for gh actions: #2

pkg/rules/rules.go

pkg/config/config.go

pkg/rules/compile.go

pkg/rules/rules.go

pkg/fileserver/fileserver.go

pkg/rules/unzip.go

akpsgit · 2023-08-31T15:40:47Z

no need for this in the makefile:

api: ## Generating API code
	@(echo "Generating API code ..." )
	@(cd api; ./generate.sh)

cmd/root.go

pkg/rules/compile.go

pkg/config/config.go

pkg/rules/rules.go

yara-rule-server-example

pkg/rules/rules.go

Tehsmash

LGTM, there are a few more places which need the error wrapping fixed.

We can copy this openclarity/vmclarity#668 and enable the linter to check this and fix it in a follow up.

pkg/rules/unzip.go

pkg/rules/compile.go

pbalogh-sa added 7 commits August 23, 2023 09:54

download and unarchive

6fdcd49

add scheduler

5d1e345

fix headers

35f2837

add gh actions

694e666

fix gh action

9b869c0

fix typo

be6e571

fix

e4abffb

pbalogh-sa marked this pull request as ready for review August 23, 2023 14:21

update example config

994a7c1

pbalogh-sa requested a review from akpsgit August 29, 2023 08:36

pbalogh-sa self-assigned this Aug 29, 2023

pbalogh-sa requested a review from FrimIdan August 29, 2023 08:37

Tehsmash requested changes Aug 29, 2023

View reviewed changes

FrimIdan reviewed Aug 30, 2023

View reviewed changes

pbalogh-sa added 2 commits August 30, 2023 16:50

remove .github

b1b38ec

rename example config

b13bc56

pbalogh-sa added 3 commits August 31, 2023 10:55

review

34b4dc9

update config

376a3f6

add healthcheck

410e483

akpsgit reviewed Aug 31, 2023

View reviewed changes

pkg/rules/rules.go Outdated Show resolved Hide resolved

akpsgit reviewed Aug 31, 2023

View reviewed changes

pkg/rules/rules.go Outdated Show resolved Hide resolved

akpsgit reviewed Aug 31, 2023

View reviewed changes

pkg/config/config.go Outdated Show resolved Hide resolved

akpsgit reviewed Aug 31, 2023

View reviewed changes

pkg/rules/compile.go Outdated Show resolved Hide resolved

akpsgit reviewed Aug 31, 2023

View reviewed changes

pkg/rules/rules.go Outdated Show resolved Hide resolved

akpsgit reviewed Aug 31, 2023

View reviewed changes

pkg/fileserver/fileserver.go Outdated Show resolved Hide resolved

akpsgit reviewed Aug 31, 2023

View reviewed changes

pkg/rules/unzip.go Outdated Show resolved Hide resolved

review

3b8dabe

Tehsmash requested changes Sep 1, 2023

View reviewed changes

cmd/root.go Outdated Show resolved Hide resolved

cmd/root.go Outdated Show resolved Hide resolved

cmd/root.go Show resolved Hide resolved

pkg/rules/compile.go Outdated Show resolved Hide resolved

pkg/config/config.go Outdated Show resolved Hide resolved

pbalogh-sa added 4 commits September 5, 2023 15:57

review

b479537

updates

4494a13

remove unused config values

ba19789

add sample config into dockerfile

d38c85a

Tehsmash reviewed Sep 6, 2023

View reviewed changes

pbalogh-sa mentioned this pull request Sep 6, 2023

feat: yara support openclarity/vmclarity#638

Merged

7 tasks

review

61aa70b

pbalogh-sa requested a review from a team as a code owner September 6, 2023 12:58

merge main

be64edb

Tehsmash requested changes Sep 8, 2023

View reviewed changes

pkg/rules/rules.go Outdated Show resolved Hide resolved

pkg/rules/rules.go Outdated Show resolved Hide resolved

FrimIdan reviewed Sep 10, 2023

View reviewed changes

pkg/rules/rules.go Outdated Show resolved Hide resolved

FrimIdan reviewed Sep 10, 2023

View reviewed changes

pkg/rules/rules.go Outdated Show resolved Hide resolved

FrimIdan reviewed Sep 10, 2023

View reviewed changes

pkg/rules/rules.go Outdated Show resolved Hide resolved

pbalogh-sa added 2 commits September 11, 2023 09:31

review

bbae120

fix

2370ce2

Tehsmash requested changes Sep 11, 2023

View reviewed changes

pkg/rules/rules.go Outdated Show resolved Hide resolved

Tehsmash requested changes Sep 11, 2023

View reviewed changes

pkg/rules/rules.go Outdated Show resolved Hide resolved

pkg/rules/rules.go Outdated Show resolved Hide resolved

pkg/rules/rules.go Outdated Show resolved Hide resolved

pkg/rules/rules.go Outdated Show resolved Hide resolved

pbalogh-sa added 2 commits September 11, 2023 10:26

fix lint

6e405c8

update error logging

8ff873f

Tehsmash approved these changes Sep 12, 2023

View reviewed changes

pbalogh-sa requested a review from akpsgit September 12, 2023 09:13

akpsgit approved these changes Sep 12, 2023

View reviewed changes

pbalogh-sa added this pull request to the merge queue Sep 12, 2023

Merged via the queue into main with commit d4fcd75 Sep 12, 2023
3 checks passed

pbalogh-sa deleted the download-and-server-rules branch September 12, 2023 11:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Download rules and unarchive them #1

Download rules and unarchive them #1

pbalogh-sa commented Aug 23, 2023

Tehsmash commented Aug 29, 2023

FrimIdan commented Aug 30, 2023

pbalogh-sa commented Aug 30, 2023

akpsgit commented Aug 31, 2023

Tehsmash left a comment

Download rules and unarchive them #1

Download rules and unarchive them #1

Conversation

pbalogh-sa commented Aug 23, 2023

Tehsmash commented Aug 29, 2023

FrimIdan commented Aug 30, 2023

pbalogh-sa commented Aug 30, 2023

akpsgit commented Aug 31, 2023

Tehsmash left a comment

Choose a reason for hiding this comment