-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scanresult): resource cleanup status refactor #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b9f83cf
to
32281e6
Compare
fishkerez
reviewed
Sep 14, 2023
fishkerez
reviewed
Sep 14, 2023
fishkerez
reviewed
Sep 14, 2023
chrisgacsal
requested changes
Sep 14, 2023
154049b
to
923dba2
Compare
8b78c6a
to
91f4a25
Compare
79b1b9b
to
b272f02
Compare
chrisgacsal
previously approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
45b25b6
to
0502b32
Compare
chrisgacsal
approved these changes
Sep 25, 2023
chrisgacsal
requested changes
Sep 25, 2023
fishkerez
reviewed
Sep 26, 2023
7 tasks
chrisgacsal
previously approved these changes
Sep 29, 2023
b785b13
to
b8c9c83
Compare
chrisgacsal
approved these changes
Sep 29, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
component:api
Issues related to API
enhancement
New feature or request
go
Pull requests that update Go code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the
ResourceCleanupState
for the new object, and also enforces the proper state transitions when the API is called.related issue: #664
Type of Change
[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist