Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): add new provider api object #714

Merged
merged 8 commits into from
Oct 3, 2023
Merged

feat(api): add new provider api object #714

merged 8 commits into from
Oct 3, 2023

Conversation

paralta
Copy link
Contributor

@paralta paralta commented Sep 26, 2023 •
edited

Description

Part 1/3 of issue #637. Please find more feature design details in discussion #581.

  • Add provider object to API
  • Add providers path to API
  • Add provider table to Database
  • Add provider controller to API server
  • Add provider methods to Backend client

Type of Change

[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@paralta paralta self-assigned this Sep 26, 2023
@paralta paralta added the component:api Issues related to API label Sep 26, 2023
@paralta paralta linked an issue Sep 26, 2023 that may be closed by this pull request
Create new API objects #637
Closed
@paralta paralta marked this pull request as ready for review September 26, 2023 15:58
@paralta paralta requested a review from a team as a code owner September 26, 2023 15:58
@fishkerez
Copy link
Contributor

I think the PR and the issue lacks the motivation behind adding the new Provider object. Can we elaborate on this a bit more?

@Tehsmash
Copy link
Contributor

Tehsmash commented Sep 27, 2023 •
edited

I think the PR and the issue lacks the motivation behind adding the new Provider object. Can we elaborate on this a bit more?

The issue is part of an epic it is linked at the top of the issue, openclarity/openclarity#723, the design document that was completed gives the full motivation for the new provider object.

Tehsmash
Tehsmash requested changes Sep 27, 2023
View reviewed changes
api/openapi.yaml Outdated Show resolved Hide resolved
pkg/apiserver/database/gorm/provider.go Outdated Show resolved Hide resolved
@paralta paralta force-pushed the issue637-provider-api branch 3 times, most recently from e721e20 to 8f424f4 Compare September 29, 2023 12:40
@paralta paralta mentioned this pull request Sep 29, 2023
Merged
7 tasks
Tehsmash
Tehsmash requested changes Oct 2, 2023
View reviewed changes
pkg/apiserver/database/gorm/odata.go Outdated Show resolved Hide resolved
@paralta paralta marked this pull request as draft October 2, 2023 08:34
@paralta paralta force-pushed the issue637-provider-api branch 2 times, most recently from a971705 to db6244b Compare October 2, 2023 11:16
@paralta
Copy link
Contributor Author

paralta commented Oct 2, 2023

thank you so much for all the feedback 😄 I just updated the PR and added a small test, please have a look

@paralta paralta marked this pull request as ready for review October 2, 2023 11:20
@chrisgacsal
Copy link
Contributor

@paralta Could you pls rebase this PR to the latest main?

@paralta
Copy link
Contributor Author

paralta commented Oct 2, 2023

@chrisgacsal rebased 👍

chrisgacsal
chrisgacsal approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@paralta
Copy link
Contributor Author

paralta commented Oct 3, 2023

thank you so much for reviewing!

@paralta paralta enabled auto-merge October 3, 2023 14:02
@paralta paralta added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit 5149f09 Oct 3, 2023
10 checks passed
@paralta paralta deleted the issue637-provider-api branch October 3, 2023 14:29
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
Merged
7 tasks
@chrisgacsal chrisgacsal mentioned this pull request Feb 21, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tehsmash Tehsmash Tehsmash approved these changes

@chrisgacsal chrisgacsal chrisgacsal approved these changes

@adamtagscherer adamtagscherer Awaiting requested review from adamtagscherer

@akpsgit akpsgit Awaiting requested review from akpsgit

Assignees

@paralta paralta

Labels
component:api Issues related to API
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create new API objects
6 participants
@paralta @fishkerez @Tehsmash @chrisgacsal @adamtagscherer @akpsgit