-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add new provider api object #714
Conversation
5b9953e
to
3fdd9ba
Compare
I think the PR and the issue lacks the motivation behind adding the new Provider object. Can we elaborate on this a bit more? |
The issue is part of an epic it is linked at the top of the issue, openclarity/openclarity#723, the design document that was completed gives the full motivation for the new provider object. |
e721e20
to
8f424f4
Compare
a971705
to
db6244b
Compare
thank you so much for all the feedback 😄 I just updated the PR and added a small test, please have a look |
@paralta Could you pls rebase this PR to the latest main? |
db6244b
to
d39c811
Compare
@chrisgacsal rebased 👍 |
d39c811
to
7c67262
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
thank you so much for reviewing! |
Description
Part 1/3 of issue #637. Please find more feature design details in discussion #581.
Type of Change
[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist