feat(api): add provider to asset and to asset scan #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Tehsmash
requested changes
Oct 2, 2023
paralta
force-pushed
the
issue637-add-provider-to-asset
branch
from
d35b0ed
to
968ac4d
Compare
paralta
changed the title
paralta
force-pushed
the
issue637-add-provider-to-asset
branch
from
968ac4d
to
ed3629b
Compare
paralta
force-pushed
the
issue637-add-provider-to-asset
branch
from
ed3629b
to
4db6a8c
Compare
paralta
force-pushed
the
issue637-add-provider-to-asset
branch
from
4db6a8c
to
d8ebdb0
Compare
akpsgit
approved these changes
Oct 4, 2023
|
@Tehsmash can you please review this one? it is blocked with your change request |
Tehsmash
approved these changes
Oct 4, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Last change to close Issue #637, blocked by PR #714 (only last 2 commits are actually for the current PR).
Please find feature design details in discussion #581.
Assetcan be found by differentProviders, therefore the asset object needs aprovidersfield to track the list of providers where it was found.Asset Scanneeds to be assigned aProviderwhich will be responsible for picking it up, therefore the asset scan object needs aproviderfield to track it.Type of Change
[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist