Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(uibackend): repeated items in impact dashboard #943

Merged
merged 2 commits into from
Nov 28, 2023
Merged

fix(uibackend): repeated items in impact dashboard #943

merged 2 commits into from
Nov 28, 2023

Conversation

paralta
Copy link
Contributor

@paralta paralta commented Nov 14, 2023 •
edited

Description

#890

  • Refactor to make findings keys for different families more consistent
  • Add new key that will be independent of where vulnerability/malware is found (e.g. package/path). Let me know if you have any suggestions to improve the naming here :)

before exploits -> after exploits

before malware -> after malware-after

In these examples the number of assets scanned was different, hence the discrepancies in the asset counts.

Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@paralta paralta added component:ui-backend component:ui Issues related to UI/Frontend labels Nov 14, 2023
@paralta paralta self-assigned this Nov 14, 2023
@paralta paralta requested a review from a team as a code owner November 14, 2023 14:12
@paralta paralta linked an issue Nov 14, 2023 that may be closed by this pull request
Findings impact dashboard showing repeated items #890
Closed
2 tasks
lgecse
lgecse previously approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@lgecse lgecse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is HUGE, thanks @paralta ! :)

@lgecse lgecse requested a review from a team November 14, 2023 14:30
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@paralta paralta marked this pull request as draft November 14, 2023 17:41
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@paralta paralta marked this pull request as ready for review November 15, 2023 13:22
Tehsmash
Tehsmash requested changes Nov 16, 2023
View reviewed changes
pkg/shared/findingkey/malware.go Outdated Show resolved Hide resolved
@paralta paralta marked this pull request as draft November 16, 2023 16:16
@paralta paralta mentioned this pull request Nov 21, 2023
Merged
7 tasks
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@paralta paralta changed the title fix(uibackend): modify finding unique keys fix(uibackend): repeated items in impact dashboard Nov 22, 2023
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@paralta paralta marked this pull request as ready for review November 23, 2023 10:10
@github-actions GitHub Actions
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr943-705b515113711eae8f0f754ac93d4fddf83ba96a
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr943-705b515113711eae8f0f754ac93d4fddf83ba96a
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr943-705b515113711eae8f0f754ac93d4fddf83ba96a
  • ghcr.io/openclarity/vmclarity-ui-dev:pr943-705b515113711eae8f0f754ac93d4fddf83ba96a
  • ghcr.io/openclarity/vmclarity-cli-dev:pr943-705b515113711eae8f0f754ac93d4fddf83ba96a

@paralta paralta added this pull request to the merge queue Nov 28, 2023
Merged via the queue into main with commit 770e3f1 Nov 28, 2023
33 checks passed
@paralta paralta deleted the issue890-finding-keys branch November 28, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tehsmash Tehsmash Tehsmash approved these changes

@lgecse lgecse lgecse left review comments

Assignees

@paralta paralta

Labels
component:ui Issues related to UI/Frontend component:ui-backend
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Findings impact dashboard showing repeated items
3 participants
@paralta @Tehsmash @lgecse