Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui): improve findings impact dashboard #972

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

paralta
Copy link
Contributor

@paralta paralta commented Nov 21, 2023

Description

#890

Move the changes below out of #943

  • Display rootkit message since too many unknown names

before rootkits -> after rootkits-after

  • Display misconfiguration Message in the dashboard instead of the Test Description.

before misconfigurations -> after misconfigurations-after

In these examples the number of assets scanned was different, hence the discrepancies in the asset counts.

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@paralta paralta requested a review from a team as a code owner November 21, 2023 16:53
@paralta paralta force-pushed the improve-findings-impact-dashboard branch from 972c923 to 2863b3e Compare November 21, 2023 16:53
@paralta paralta self-assigned this Nov 21, 2023
@paralta paralta added component:ui-backend component:ui Issues related to UI/Frontend labels Nov 21, 2023
@paralta paralta linked an issue Nov 21, 2023 that may be closed by this pull request
2 tasks
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr972-d65e6c378dd03ad4c1878f3ec028985d1fb1cb6b
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr972-d65e6c378dd03ad4c1878f3ec028985d1fb1cb6b
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr972-d65e6c378dd03ad4c1878f3ec028985d1fb1cb6b
  • ghcr.io/openclarity/vmclarity-ui-dev:pr972-d65e6c378dd03ad4c1878f3ec028985d1fb1cb6b
  • ghcr.io/openclarity/vmclarity-cli-dev:pr972-d65e6c378dd03ad4c1878f3ec028985d1fb1cb6b

Copy link
Member

@ramizpolic ramizpolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One note though, is there a (human-readable) limit to the size of the message displayed in the table? I am guessing there could be some rather long messages that would break the table.

@paralta
Copy link
Contributor Author

paralta commented Nov 22, 2023

@ramizpolic thanks for reviewing! That is a good point, I am not aware of any limits currently applied here.

Character limits as well as spacings in tables (like this example) definitely need some overall improvements.
Screenshot 2023-11-22 at 10 22 30

@gallotamas
Copy link
Contributor

Character limits as well as spacings in tables (like this example) definitely need some overall improvements.

Yes, we definitely need this. I would suggest to do it with the introduction of a UI component library (we agreed on MUI). A proper table component handles most of these use cases out of the box.

@ramizpolic ramizpolic added this pull request to the merge queue Nov 23, 2023
Merged via the queue into main with commit d68ab44 Nov 23, 2023
35 checks passed
@ramizpolic ramizpolic deleted the improve-findings-impact-dashboard branch November 23, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ui Issues related to UI/Frontend component:ui-backend
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Findings impact dashboard showing repeated items
3 participants