-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ui): improve findings impact dashboard #972
Conversation
972c923
to
2863b3e
Compare
Hey! Your images are ready:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
One note though, is there a (human-readable) limit to the size of the message displayed in the table? I am guessing there could be some rather long messages that would break the table.
@ramizpolic thanks for reviewing! That is a good point, I am not aware of any limits currently applied here. Character limits as well as spacings in tables (like this example) definitely need some overall improvements. |
Yes, we definitely need this. I would suggest to do it with the introduction of a UI component library (we agreed on MUI). A proper table component handles most of these use cases out of the box. |
Description
#890
Move the changes below out of #943
before
-> after ![rootkits-after](https://private-user-images.githubusercontent.com/46568597/282764744-23e405eb-9f70-4f49-bf92-2c3342e37a13.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ1MjYyNTYsIm5iZiI6MTcyNDUyNTk1NiwicGF0aCI6Ii80NjU2ODU5Ny8yODI3NjQ3NDQtMjNlNDA1ZWItOWY3MC00ZjQ5LWJmOTItMmMzMzQyZTM3YTEzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI0VDE4NTkxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI3MWJkOGVlZDg1ODlkMGE2ODA2YjcyNTFkZWVjYmM1MTMyMTQ0OTgwODFhZTEzZmEyOWQ5NTQ3ODhkZTFhM2ImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.miHSjo8SIduy5mZg0BZYDrs314-a7HrTJTEmSneBQLI)
Message
in the dashboard instead of theTest Description
.before
-> after ![misconfigurations-after](https://private-user-images.githubusercontent.com/46568597/282801711-5a509344-4ff8-4617-b202-5eab5278ec87.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ1MjYyNTYsIm5iZiI6MTcyNDUyNTk1NiwicGF0aCI6Ii80NjU2ODU5Ny8yODI4MDE3MTEtNWE1MDkzNDQtNGZmOC00NjE3LWIyMDItNWVhYjUyNzhlYzg3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI0VDE4NTkxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg1ODZkMTI2ZjcwODNjMDRkNDBmNDIyYTYwZjljMmM4ZDFiYWQyMThkMzFjZmFlODdjZTMwN2VmZmZkMmUyZTkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.wut9ZXclJoAVXLV6sXhUrDESUKa0DXqaTHvBTHxAGec)
In these examples the number of assets scanned was different, hence the discrepancies in the asset counts.
Type of Change
[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist