Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/rm nowcasting utils #13

Merged
merged 20 commits into from
Jan 30, 2024
Merged

Issue/rm nowcasting utils #13

merged 20 commits into from
Jan 30, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Dec 20, 2023

Pull Request

Description

Remove Nowcasting-utils
#12

I had to pin a few repos, to get it working. I thought it was better to pin them to get some green, then its easier to upgrade and see where things need changing

How Has This Been Tested?

CI test

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield marked this pull request as draft December 21, 2023 08:17
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3cdd785) 59.53% compared to head (337abe5) 59.36%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   59.53%   59.36%   -0.18%     
==========================================
  Files           6        6              
  Lines         472      470       -2     
==========================================
- Hits          281      279       -2     
  Misses        191      191              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterdudfield peterdudfield requested a review from dfulu December 21, 2023 17:10
@peterdudfield peterdudfield marked this pull request as ready for review December 21, 2023 17:10
@peterdudfield peterdudfield merged commit 9732061 into main Jan 30, 2024
5 checks passed
@peterdudfield peterdudfield deleted the issue/rm-nowcasting-utils branch January 30, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant