Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base_model.py #110

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Update base_model.py #110

merged 4 commits into from
Dec 21, 2023

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Dec 20, 2023

Pull Request

Description

Fix targets to target
pin ocf_datapipes to 2.3.1 until upgrades are made for 3.0.0

Helps with openclimatefix/PVNet-summation#13

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield requested a review from dfulu December 20, 2023 17:54
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (48a282a) 50.85% compared to head (cf0c21c) 50.85%.
Report is 2 commits behind head on main.

Files Patch % Lines
pvnet/models/base_model.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage   50.85%   50.85%           
=======================================
  Files          26       26           
  Lines        1701     1701           
=======================================
  Hits          865      865           
  Misses        836      836           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterdudfield peterdudfield merged commit 4190880 into main Dec 21, 2023
2 of 3 checks passed
@peterdudfield peterdudfield deleted the fix-common-metrics branch December 21, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants