Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base_model.py #110

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Update base_model.py #110

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab8c14a
Update base_model.py
peterdudfield Dec 20, 2023
f262fc9
ocf_datapipes==2.2.7
peterdudfield Dec 20, 2023
cf0c21c
ocf_datapipes==2.3.1
peterdudfield Dec 20, 2023
d16bed9
Merge branch 'main' into fix-common-metrics
peterdudfield Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pvnet/models/base_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@
# Take median value for remaining metric calculations
y_hat = self._quantiles_to_prediction(y_hat)

common_metrics_each_step = common_metrics(predictions=y_hat, targets=y)
common_metrics_each_step = common_metrics(predictions=y_hat, target=y)

Check warning on line 373 in pvnet/models/base_model.py

View check run for this annotation

Codecov / codecov/patch

pvnet/models/base_model.py#L373 

Added line #L373 was not covered by tests
mse_each_step = common_metrics_each_step["rmse"] ** 2
mae_each_step = common_metrics_each_step["mae"]

Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ocf_datapipes>=2.3.0
ocf_datapipes==2.3.1
ocf_ml_metrics
numpy
pandas
Expand Down
Loading