add recent power values as features

[peterdudfield]

Pull Request

Description

Add recent values values as a feature. Before we jsut have the recent power mean is a recent time period.

TODO run experiment with and without this. The experiment should perhaps just be trying to forecast 1 hour in 15 mins blocks. And we would expect this to make a difference

How Has This Been Tested?

CI tests

• Yes

Checklist:

• My code follows OCF's coding style guidelines
• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• I have checked my code and corrected any misspellings

[zakwatts]

Changes might need to be made when we use the flag --no-live-pv, to remove PV features during inference for metadata only backtests.

[peterdudfield]

yea, good shout, ill have a look at that. Probably the same for the mean power values above.

Although the default is 0 values, so it might be ok

[zakwatts]

The new features would need to be removed from here:

pv-site-prediction/psp/models/multi.py

Line 30 in 7a46fd0

def get_features_without_pv(self, x: X, is_training: bool = False) -> Features:

[zakwatts]

currently these pv features are hardcoded (in line 48):
pv_derived_features = ["recent_power", "h_max", "h_median", "h_mean"]
nan_pv_derived_features = ["recent_power_nan", "h_max_nan", "h_median_nan", "h_mean_nan"]

[peterdudfield]

I think I found it

[zakwatts]

Looks good. It would probably make sense to add a test somewhere for the --no-live-pv. (which is my bad as I didn't make one when i first implemented this!)

[zakwatts]

Looks good