-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add recent power values as features #115
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
20165a6
add recent power values as features
peterdudfield d700930
lint and reduce default to 0
peterdudfield e638943
lint
peterdudfield 8ec00d3
add resislence
peterdudfield 45035ac
add len
peterdudfield 974e584
fix length
peterdudfield cce9678
add readme + eval model print statments
peterdudfield 60719ed
change recent power values to nans, when using no-live-pv
peterdudfield File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
# Recent Power | ||
|
||
The idea is to add some recent power values. | ||
The model current uses the last 30 minutes but the average power. It would be good to give the actual values as well. | ||
|
||
We used `uk_pv.py` configuration, but removed the satellite input. We used 6 recent power values. | ||
|
||
We want to A/B test and see the difference. The total MAE for all horizons | ||
|
||
| | Model | Model with recent power | | ||
|---------|-------|-------------------------| | ||
| test | 0.140 ± 0.020 | 0.122 ± 0.017 | | ||
| train |0.192 ± 0.027 | 0.182 ± 0.026 | | ||
|
||
And just for the test set (The test set is 2020-01-01 to 2021-11-00): | ||
|
||
| Horizon | MAE | MAE with recent power | | ||
|---------|------|--------| | ||
| 0 -15 | 0.14 | 0.12 | | ||
| 15-30 | 0.17 | 0.17 | | ||
| 30-45 | 0.19 | 0.19 | | ||
| 45-60 | 0.21 | 0.21 | | ||
|
||
So this just makes a difference for the first 0-15 forecast of data |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes might need to be made when we use the flag --no-live-pv, to remove PV features during inference for metadata only backtests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, good shout, ill have a look at that. Probably the same for the
mean power values
above.Although the default is 0 values, so it might be ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new features would need to be removed from here:
pv-site-prediction/psp/models/multi.py
Line 30 in 7a46fd0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently these pv features are hardcoded (in line 48):
pv_derived_features = ["recent_power", "h_max", "h_median", "h_mean"]
nan_pv_derived_features = ["recent_power_nan", "h_max_nan", "h_median_nan", "h_mean_nan"]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I found it