Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make saithrift compatible with thrift 0.14.1
How I did it:
union
bystruct
in *.thrift files as saithrift code relays on an old thrift bug which was fixed in thrift 0.11.0. Due to that BUGunios
behaves asstruct
. In SONiC there is patch to revert the fix in 0.11.0 .shared_ptr
based on thrift version. In Thrift 0.11.0 theboost::shared_ptr
is usually used. But star from 0.13.0 the boost dependency was dropped in Thrift.Verified these changes in SONIC build env with different thrift version: