[BFN] syncd-rpc build with thrift 0.14.1 #9884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msosyak
force-pushed
the
syncd_rpc_trift_14
branch
from
bd41457 to
f85ec39
Compare
5 tasks
|
@richardyu-ms Please review. |
richardyu-ms
reviewed
Feb 8, 2022
richardyu-ms
previously approved these changes
Feb 9, 2022
msosyak
force-pushed
the
syncd_rpc_trift_14
branch
from
8e330e1 to
fef4680
Compare
msosyak
force-pushed
the
syncd_rpc_trift_14
branch
from
fef4680 to
8dcd7c2
Compare
|
@qiluo-msft @richardyu-ms Are there any comments on this or could we merge it? |
richardyu-ms
approved these changes
Feb 18, 2022
bratashX
added a commit
to bratashX/sonic-buildimage
that referenced
this pull request
Apr 4, 2022
This reverts commit bec3526.
prgeor
pushed a commit
that referenced
this pull request
Apr 14, 2022
* Ported platform from master Signed-off-by: Petro Bratash <petrox.bratash@intel.com> * [BFN] Updated x86_64-accton_as9516_32d-r0/platform.json * [BFN] Refactoring and adding some functions of Thermal class (set and get thresholds and etc.) * [BFN] Fix exception when fwutil run without sudo * Revert "[BFN] syncd-rpc build with thrift 0.14.1 (#9884)" This reverts commit bec3526. * [BFN] Updated SDK to 20220127_sai_1.9.1 (#9870) Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * [BFN] updated SDE packages for BFN platforms (#10512) Updated SDE packages for bfn platform - introduced X6 profile - fixes for drop counters - fixes for platform part Co-authored-by: Andriy Kokhan <AndriyX.Kokhan@intel.com> Co-authored-by: roman_savchuk <romanx.savchuk@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #9881
Why I did it
The BFN SDK depends on thrift 0.14.1 and in the case syncd-rpc there is conflict in syncd as it should be linked with thrift 0.11.0(libsaithrift) and 0.14.1(libsai BFN impl) which are not binary compatible and caused runtime issues.
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)