Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sai ptf server v2 user guide #1512

Merged

Conversation

reshmaintel
Copy link
Contributor

User Guide for SAI thrift server. Adds info on how a user can generate automated test framework and integrate it with the user libsai.

@chrispsommers
Copy link
Contributor

LGTM, I was able to execute these instructions. If #1514 gets merged, the instructions should be updated to show how to pass option flags. If this gets merged first, I can add that to https://github.com/opencomputeproject/SAI/pull/1514as well (i.e. update this README).

@chrispsommers
Copy link
Contributor

Hi @reshmaintel you need to rebase and signoff for the DCO to pass, instructions for this are here: https://github.com/opencomputeproject/SAI/pull/1512/checks?check_run_id=7046496912 (I did same on my #1514 and had to fix, oops)

@vmytnykx
Copy link
Contributor

#1514 LGTM, so once DCO is fixed, it is good to go. @chrispsommers don't you mind to update the user guide as separate PR once the #1514 is merged ?

@chrispsommers
Copy link
Contributor

@vmytnykx I will update the User guide after #1514 is merged.

SAI-PTF-V2 User Guide has details on how a user can build the SAI Thrift server and integrate it with their own specific libsai

Signed-off-by: Reshma Sudarshan <reshma.sudarshan@intel.com>
Signed-off-by: Reshma Sudarshan <reshma.sudarshan@intel.com>
pip install ctypesgen
```

Apache thrift 0.11.0
Copy link
Collaborator

@richardyu-ms richardyu-ms Jul 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sonic-net/sonic-buildimage#9884

it should be able to build it with thrift 0.14.0?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardyu-ms yes, the saithrift can be built with thrift 0.14.1 also. Verified already. Once this PR is merged, I will update the doc with thrift 0.14 info included.

Copy link
Collaborator

@richardyu-ms richardyu-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the thrift version, others are LGTM. Thanks for this useful doc!

@richardyu-ms richardyu-ms merged commit 9ef82c6 into opencomputeproject:master Jul 25, 2022
chrispsommers pushed a commit to chrispsommers/SAI that referenced this pull request Aug 4, 2022
* Create SAI_PTF_user-guide.md

SAI-PTF-V2 User Guide has details on how a user can build the SAI Thrift server and integrate it with their own specific libsai

Signed-off-by: Reshma Sudarshan <reshma.sudarshan@intel.com>

* Create readme.md

Signed-off-by: Reshma Sudarshan <reshma.sudarshan@intel.com>
Signed-off-by: Chris Sommers <chrispsommers@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants