MAINTAINERS: add new maintainers to go-digest #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaron and Derek have long been instrumental in the maintenance and integration of the original `digest` package. Since this package provides such critical functionality, having their experience on board will ensure that additions to this package can be made with confidence. Signed-off-by: Stephen J Day <stephen.day@docker.com>
|
lets procure other LGTMs from the @opencontainers/go-digest-maintainers |
|
LGTM |
|
lgtm |
|
On Tue, Jan 10, 2017 at 02:19:43AM -0800, Jonathan Boulle wrote:
Merged #25.
Maintainer changes are supposed to take a 66% vote by current
maintainers [1]. Although that won't be documented in this repo until
#20 lands, I think the idea is that it applies from the time the TOB
creates the new OCI Project, otherwise it's not clear how the project
should be governed between creation and doc-landing.
[1]: https://github.com/opencontainers/project-template/blob/9f95b15139365f60f27e5cc3028ddad20429a5fe/MAINTAINERS_GUIDE.md#how-are-maintainers-added
|
|
LGTM |
|
@opencontainers/go-digest-maintainers Please mark this with your LGTM. If this doesn't pass, we'll merge #26 and revert the change. |
|
LGTM. |
|
LGTM |
wking
added a commit
to wking/nmbug-oci
that referenced
this pull request
Feb 1, 2017
Most of the voting happened in the GitHub PR [1], which passed +5 -0 #2, with Brandon Philips and Jason Bouzane not weighing in. [1]: opencontainers/go-digest#25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aaron and Derek have long been instrumental in the maintenance and
integration of the original
digestpackage. Since this packageprovides such critical functionality, having their experience on board
will ensure that additions to this package can be made with confidence.
Signed-off-by: Stephen J Day stephen.day@docker.com