Skip to content

Commit

Permalink
CONTRIBUTING: Allow collaborative pull requests
Browse files Browse the repository at this point in the history
For runtime-spec, there are often PRs that pickup and reroll another
user's commits (e.g. opencontainers/runtime-spec#337). As long as the
Signed-off-by entries are there (for the DCO) and the new PR
references the earlier work (to avoid maintainer confusion), I see no
problem with this sort of collaboration.

I thought about replacing the old wording with words like the above
paragraph, but it seemed overly prescriptive.

Signed-off-by: W. Trevor King <wking@tremily.us>
  • Loading branch information
wking committed May 23, 2016
1 parent b6d2e98 commit 84b4812
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ committing your changes. Most editors have plugins that do this automatically.
Pull requests descriptions should be as clear as possible and include a
reference to all the issues that they address.

Pull requests must not contain commits from other users or branches.

Commit messages must start with a capitalized and short summary
written in the imperative, followed by an optional, more detailed
explanatory text which is separated from the summary by an empty line.
Expand Down

0 comments on commit 84b4812

Please sign in to comment.