[1.1] nsexec: Check for errors in write_log()

[rata]

This is a backport of #3712 for release 1.1 branch.

---

First, check if strdup() fails and error out.

While we are there, the else case was missing brackets, as we only need to check ret in the else case. Fix that too

Signed-off-by: Rodrigo Campos rodrigoca@microsoft.com
(cherry picked from commit 5ce511d)

[rata]

Test failures are unrelated to runc code, it seems like a network issue:

curl: (22) The requested URL returned error: 404 
Failed to get https://github.com/docker-library/busybox/raw/dist-amd64/stable/glibc/busybox.tar.xz

Will re push in a few minutes.

[rata]

Hmm, it seems that link is not working anymore. Tests might need to use a new URL :(

[tianon]

#3701 (and the other PR it links to) 👀

[rata]

@tianon do we need to backport that to 1.1, then?

[tianon]

I'm not a maintainer, just a long time contributor 😅 If the 1.1 branch is going to be maintained/used though, it probably does make sense to backport those CI fixes IMO.

[kolyshkin]

@rata CI fixes were landed, please rebase.

[rata]

@kolyshkin thanks! Rebased 🤞

[rata]

Grr, tests are not passing due to this unit test:

=== RUN   TestFdLeaksSystemd
    exec_test.go:1838: extra fd 29 -> 
    exec_test.go:1838: extra fd 31 -> 
    exec_test.go:1841: found 2 extra fds after container.Run
--- FAIL: TestFdLeaksSystemd (0.19s)

[rata]

It seems to be a flaky test, now test pass fine!

@kolyshkin should I open an issue for this flaky test?

[kolyshkin]

It seems to be a flaky test, now test pass fine!

@kolyshkin should I open an issue for this flaky test?

Yes please (I think this is the first time I am seeing this).

[kolyshkin]

LGTM

[kolyshkin]

It seems to be a flaky test, now test pass fine!

@kolyshkin should I open an issue for this flaky test?

Opened #3735 trying to attack this (although I'm still not quite sure how the failure happened, the fix makes sense overall).

[AkihiroSuda]

This branch is out-of-date with the base branch

Looks like another rebasing is needed for release-1.1 branch

[rata]

Done, all should be green now (fedora still running, the rest is green)