[1.1] Fix CI #3723
Closed
[1.1] Fix CI #3723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently only amd64 and arm64v8 tarball have been checked in testdata, while busybox bundle is downloaded on fly, and supports multiple architectures. To enable integration tests for more architectures, the hello world bundle is replaced by busybox one. Signed-off-by: Shengjing Zhu <zhsj@debian.org> (cherry picked from commit 66bf371)
Fix issue 3699 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
thaJeztah
previously approved these changes
Feb 6, 2023
|
I'm not sure if the vagrant failure is valid (but not caused by this). Seems weird it doesn't happen on main, though. Will repush |
Signed-off-by: Tianon Gravi <admwiggin@gmail.com> (cherry picked from commit 6d28928)
|
@kolyshkin @thaJeztah Do you want to carry forward this PR and fix vagrant (vagrant failure seems legit, the other fails seems like azure downtime or some more fixes needed :-/) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I opened PR #3721 the CI fails due to downloading the busybox image. This PR should fix that.
I'm backporting #3700 #3701 and #3526 for this. The fist two are fixes for this (and is simpler to backport both than to bakport one and fix the conflicts). The last one (#3526) I've backported it too, so I can apply the first two without conflicts. It only changes tests, so it seems safe to backport.
I think backporting all of these makes it simpler also to backport any more change needed in the future (as these files are in sync between 1.1 branch and main), and as they only change the tests it seems fine IMHO. Let me know if you prefer more chirurgical changes and to deal with conflicts when backporting.