Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: clarify Linux mount options #1181

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Feb 10, 2023

The former wording was inconsistent with runc, crun, youki, etc.

Several mount(8) options such as X-mount.mode are unimplemented in those OCI runtimes, and vice versa (tmpcopyup, rro, etc.)

The option table added in this commit conforms to runc 1.1, but acl and noacl are excluded as the runc implementation seems wrong. (runc issue: opencontainers/runc#3738)

The former wording was inconsistent with runc, crun, youki, etc.

Several `mount(8)` options such as `X-mount.mode` are unimplemented in those OCI runtimes,
and vice versa (`tmpcopyup`, `rro`, etc.)

The option table added in this commit conforms to runc 1.1, but `acl`
and `noacl` are excluded as the runc implementation seems wrong (runc issue 3738).

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda force-pushed the clarify-mount-options branch from b35b6e2 to 6c638b1 Compare February 10, 2023 06:21
If a custom option string is already recognized by [`mount(8)`][mount.8], the runtime SHOULD follow the behavior of [`mount(8)`][mount.8].

Runtimes SHOULD pass unknown options to [`mount(2)`][mount.2] via the fifth argument (`const void *data`).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(The list of the implemented options is printed in runc features)

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda added this to the v1.1.0 milestone Feb 10, 2023
Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's very verbose, but I think that's fair 👍 (and appreciate the clear effort that's gone into making sure it's as terse as it can reasonably be while still being clear)

@tianon tianon merged commit 4f38d2d into opencontainers:main Feb 10, 2023
@AkihiroSuda
Copy link
Member Author

It's very verbose, but I think that's fair 👍 (and appreciate the clear effort that's gone into making sure it's as terse as it can reasonably be while still being clear)

Thanks, can we merge this too, so that higher-level engines can detect the supported mount options ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants