Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.1.0-rc.2 #1192

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Release v1.1.0-rc.2 #1192

merged 3 commits into from
Apr 17, 2023

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Mar 28, 2023 •
edited
Loading

Call for vote: https://groups.google.com/a/opencontainers.org/g/dev/c/fnCiFoXBsiI/m/fbbmbs19EQAJ
Closes Tue Apr 4 03:33:57 AM UTC 2023

After releasing v1.1.0-rc.2, I propose feature-freezing the main branch until releasing v1.1.0 GA, with an exception for PRs that were opened before proposing v1.1.0-rc.2. (e.g., #1188 #1190 #1191)

Changes (v1.0.2→v1.1.0-rc.1)

See #1175

Changes (v1.1.0-rc.1→v1.1.0-rc.2)

Additions

Minor fixes and documentation

@AkihiroSuda AkihiroSuda added this to the v1.1.0 milestone Mar 28, 2023
@AkihiroSuda AkihiroSuda mentioned this pull request Mar 28, 2023
Closed
vbatts
vbatts approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@vbatts vbatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kolyshkin
kolyshkin approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe
Copy link
Member

I think we also need: #1193

@AkihiroSuda
Copy link
Member Author

I think we also need: #1193

Updated PR to include this

@AkihiroSuda AkihiroSuda requested review from vbatts and kolyshkin April 3, 2023 04:49
thaJeztah
thaJeztah approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hqhq
hqhq approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@hqhq hqhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda
Copy link
Member Author

@vbatts @kolyshkin May I assume this one still LGTY?

kolyshkin
kolyshkin approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda
ChangeLog: Document changes since v1.1.0-rc.1
54f948c 
Through 2ee82c5 (2023-04-05)

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
version: release v1.1.0-rc.2
a5b4da4 
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
version: v1.1.0-rc.2-dev
4ee185a 
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
Copy link
Member Author

Rebased to include:

@AkihiroSuda
Copy link
Member Author

@opencontainers/runtime-spec-maintainers Please vote (if you haven't) 🙏

@utam0k
Copy link
Member

utam0k commented Apr 6, 2023

I can't wait to release the latest version 🚀

@AkihiroSuda
Copy link
Member Author

@opencontainers/runtime-spec-maintainers We need 7 LGTMs to make this release. (Currently we have 4)

giuseppe
giuseppe approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utam0k utam0k mentioned this pull request Apr 12, 2023
Open
@dqminh
Copy link
Contributor

dqminh commented Apr 13, 2023

LGTM

@thaJeztah
Copy link
Member

@mrunalp @cyphar @tianon @vbatts @crosbymichael ptal

cyphar
cyphar approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AkihiroSuda
Copy link
Member Author

  • Voters: 10 (11 maintainers minus myself)
  • Actual votes: 7
  • Approvals: 7

Let me merge this and make a release

@AkihiroSuda AkihiroSuda merged commit 33f13d1 into opencontainers:main Apr 17, 2023
@AkihiroSuda AkihiroSuda mentioned this pull request May 22, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hqhq hqhq hqhq approved these changes

@kolyshkin kolyshkin kolyshkin approved these changes

@cyphar cyphar cyphar approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@giuseppe giuseppe giuseppe approved these changes

@dqminh dqminh dqminh approved these changes

@crosbymichael crosbymichael Awaiting requested review from crosbymichael crosbymichael is a code owner

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@tianon tianon Awaiting requested review from tianon tianon is a code owner

@vbatts vbatts Awaiting requested review from vbatts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
9 participants
@AkihiroSuda @giuseppe @utam0k @dqminh @thaJeztah @vbatts @cyphar @kolyshkin @hqhq