-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade node to 18 #6439
Upgrade node to 18 #6439
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6439 +/- ##
===========================================
- Coverage 86.66% 86.33% -0.34%
===========================================
Files 731 728 -3
Lines 126469 126587 +118
Branches 11911 11979 +68
===========================================
- Hits 109602 109284 -318
- Misses 16861 17298 +437
+ Partials 6 5 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It otherwise works, but I'm getting request to http://localhost:3040/application-config failed, reason: connect ECONNREFUSED ::1:3040
only on this branch for some reason on my Mac. Wonder if it's due to my setup or not. I can access the URL with browser directly
I tested on Ubuntu 20.04.6, data seeding worked without any hiccups. I then ran the cypress tests and they also seem to be working fine (albeit a couple of tests are still broken but they are unrelated). |
a1be273
to
3bf5c24
Compare
Co-authored-by: Pyry Rouvila <pyry.rouvila@gmail.com>
@tahmidrahman-dsi remember to update CHANGELOG.md |
packages/config/package.json
Outdated
@@ -4,7 +4,7 @@ | |||
"description": "OpenCRVS public configuration microservice", | |||
"license": "MPL-2.0", | |||
"scripts": { | |||
"start": "cross-env NODE_ENV=development nodemon --exec ts-node -r tsconfig-paths/register src/index.ts", | |||
"start": "cross-env NODE_ENV=development NODE_OPTIONS=--dns-result-order=ipv4first nodemon --exec ts-node -r tsconfig-paths/register src/index.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"start": "cross-env NODE_ENV=development NODE_OPTIONS=--dns-result-order=ipv4first nodemon --exec ts-node -r tsconfig-paths/register src/index.ts", | |
"start": "cross-env NODE_ENV=development NODE_OPTIONS=--dns-result-order=ipv4first nodemon --exec ts-node -r tsconfig-paths/register src/index.ts", |
Very minor thing but some of these have double spaces in the command
@tahmidrahman-dsi I think we can merge this after doing a test by deploying to one of our environments or have we already done that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on WSL, works fine.
@tahmidrahman-dsi if you search for "16.20.0" in the code, you need to update .nvmrc, setup.sh, .github/DISCUSSION_TEMPLATE cd-manual-e2e.yml and lint-and-test.yml too please. |
Farajaland PR: opencrvs/opencrvs-farajaland#847