Upgrade node to 18 #847
Merged
Upgrade node to 18 #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikukissa
reviewed
Jan 16, 2024
.github/workflows/deploy-prod.yml
Outdated
| @@ -32,7 +32,7 @@ jobs: | |||
| timeout-minutes: 60 | |||
| strategy: | |||
| matrix: | |||
| node-version: [16.20.0] | |||
| node-version: [18.19.0] | |||
There was a problem hiding this comment.
Note that these are not actually used anywhere. I've removed these definitions in 1.4.0
There was a problem hiding this comment.
@rikukissa should I revert this, then?
There was a problem hiding this comment.
@tahmidrahman-dsi I think it's fine to keep unless you want to remove the whole matrix block
rikukissa
reviewed
Jan 16, 2024
tahmidrahman-dsi
force-pushed
the
upgrade-node@18
branch
from
bd7709c
to
c602f41
Compare
rikukissa
approved these changes
Jan 29, 2024
Zangetsu101
approved these changes
Feb 2, 2024
Zangetsu101
referenced
this pull request
in opencrvs/opencrvs-countryconfig
May 14, 2024
* Update node version in Dockerfile * Update node version in workflow yml files * Add os configuration option in package.json * Add engines configuration option in package.json * Feedback changes * Add node options NODE_OPTIONS dns-result-order `ipv4first` * Upgrade node version in workflow file * Remove matrix block
naftis
added a commit
that referenced
this pull request
Jun 5, 2024
* Code freeze 1.5.0 release * Update auth to go through gateway (#781) * fix auth api urls * add mongo url for search service * refactor: keep individual certificate endpoint only in dev * return composition id confirm registration endpoint in core (#797) * Add feature flags in application default config (#806) * chore: remove logrocket references (#811) * feature flag hotfix for client config prod * Upgrade node to 18 (#847) * Update node version in Dockerfile * Update node version in workflow yml files * Add os configuration option in package.json * Add engines configuration option in package.json * Feedback changes * Add node options NODE_OPTIONS dns-result-order `ipv4first` * Upgrade node version in workflow file * Remove matrix block * (state-transitions): remove openhim url and modify confirm registration url (#932) * Remove openhim url and modify confirm registration url * Remove openhim core and openhim console services * feat: enable gzip compression (#947) * feat: enable gzip compression * enable gzip for gateway and login * make SENTRY_DSN variable optional * fix: support node versions 18.x.x (#955) * build: use docker compose v2 in github workflow files (#956) * Merge pull request #937 from opencrvs/ocrvs-6410-mass-email-users * deps: remove openhim (#963) * Add smtp env vars in qa deploy config * Revert "Minor amend notification schema" This reverts commit b2c6e39. * fix: remove duplicate handlebars.js route * chore: update the certificate images with <image> instead of the patterns (#977) * feat: generate default address according to user's location (#978) * feat: add GATEWAY_URL env variable * feat: generate default address from user location * chore: remove initialValue from dynamicOptions * [HOTFIX] Mass email subject & content styles (#983) * Update body content styles to use linebreaks * Forward subject from variables instead of template * fix: change gateway web url to internal swarm one (#990) * docs: update CHANGELOG * set owner for backup server authorized_keys to be the backup user * minor fix to how download script cleans backup directories before applying downloaded backups * chore!: move configuration options (#1005) * Remove authentication from dashboard queries endpoint and update traefik rules * fix: remove authentication from dashboard queries endpoint and update traefik rules (#120) * Update CHANGELOG.md * Remove unintended formatting changes * Update jq images to official ones to avoid deprecation breakage (#122) * Update Docker and checkout actions to get rid of warnings (#121) * fix: add translations for different informants in print, issue & correction flow (#127) * french translation added for informants * updated changelog.md * Fix Correct item names in update modal for marriage declaration * don't require regLastLocation in Postman Event Notification (#115) * fix: simplify hierarchy now that it can be queried through graphql (#116) --------- Co-authored-by: Riku Rouvila <riku.rouvila@gmail.com> Co-authored-by: Md. Ashikul Alam <32668488+Nil20@users.noreply.github.com> Co-authored-by: Tahmid Rahman <42269993+tahmidrahman-dsi@users.noreply.github.com> Co-authored-by: tahmidrahman-dsi <tahmid.rahman@dsinnovators.com> Co-authored-by: Tameem Bin Haider <tameem.haider@dsinnovators.com> Co-authored-by: Tameem Bin Haider <haidertameem@gmail.com> Co-authored-by: tahmidrahman-dsi <tahmidrahman.dsi@gmail.com> Co-authored-by: Niko Kurtti <niko@kurtti.eu> Co-authored-by: Anamul Haque <anamul1414@gmail.com> Co-authored-by: Tareq <tareq.aziz@dsinnovators.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.