Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix py38 build #837

Merged
merged 2 commits into from
May 29, 2023
Merged

Fix py38 build #837

merged 2 commits into from
May 29, 2023

Conversation

bertsky
Copy link
Contributor

@bertsky bertsky commented Apr 26, 2023

fixes #836 i.e.

  • ability to build untagged commits manually using pip wheel (ensuring the version conforms to PEP 440, and to our actual documentation, by using + instead of .)
  • ability to compile against current OpenCV on Python 3.8 (using numpy 1.17.5 instead of 1.17.3 which does not compile anymore)

@bertsky
Copy link
Contributor Author

bertsky commented Apr 27, 2023

Note: CI failures look exactly like the CI failures on the 4.x head, so I guess this is unrelated.

Perhaps this is a regression in skbuild? See this recent change

@bertsky
Copy link
Contributor Author

bertsky commented Apr 27, 2023

Perhaps this is a regression in skbuild? See this recent change

Note this comment

@bertsky
Copy link
Contributor Author

bertsky commented May 12, 2023

No interest at all?

@asmorkalov asmorkalov self-requested a review May 29, 2023 06:56
@asmorkalov asmorkalov assigned asmorkalov and unassigned sergregory May 29, 2023
@asmorkalov asmorkalov merged commit 0ba2c80 into opencv:4.x May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wheel build for headless fails on 4.7.0 for Py38
3 participants