Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle None case for python library #838

Merged
merged 1 commit into from
May 29, 2023
Merged

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Apr 27, 2023

See scikit-build/scikit-build#940. This was a "regression" due to this now returning "None" if the path it returns points at nothing (such as in manylinux, where the python library is intentionally removed from the docker image), but it was always allowed to return None, which makes the correct fix something like this.

Also see #837.

@asmorkalov asmorkalov self-requested a review May 29, 2023 06:22
@asmorkalov asmorkalov self-assigned this May 29, 2023
@asmorkalov asmorkalov merged commit 264e05b into opencv:4.x May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants