Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for stability/metrics #338

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Fix for stability/metrics #338

merged 2 commits into from
Nov 10, 2021

Conversation

benjimin
Copy link
Contributor

@benjimin benjimin commented Nov 9, 2021

  • Address Instability and ramping resource usage #337 (explosion of metrics) by labelling metrics by endpoint, rather than by path. Because the number of distinct paths is nearly unbounded (distinguishing those is a role for logs not metrics).
  • Resolve repo staleness (previously passing tests now fail) by pinning a dependency version to the last compatible version (pending further updates).

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #338 (bf8955b) into develop (fea217d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #338   +/-   ##
========================================
  Coverage    86.22%   86.22%           
========================================
  Files           25       25           
  Lines         3077     3077           
========================================
  Hits          2653     2653           
  Misses         424      424           
Impacted Files Coverage Δ
cubedash/_model.py 92.53% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fea217d...bf8955b. Read the comment docs.

@benjimin benjimin requested a review from jeremyh November 9, 2021 21:50
Copy link
Collaborator

@jeremyh jeremyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this

@jeremyh
Copy link
Collaborator

jeremyh commented Nov 9, 2021

eodatasets regression is fixed in opendatacube/eo-datasets#220

@benjimin benjimin merged commit 6051dd6 into develop Nov 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the feature/metrics branch November 10, 2021 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants