Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for gridless stac conversions #220

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

jeremyh
Copy link
Collaborator

@jeremyh jeremyh commented Nov 9, 2021

Fix Stac conversion of datasets that don't have shape+transform information (from #216).

(DEA's older EO1 datasets don't have this information)

This was caught by Explorer's stac-api tests after the recent eodatasets release. I've expanded the test cases here to match.

@jeremyh jeremyh requested review from supermarkion and removed request for supermarkion November 9, 2021 23:24
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #220 (64e0992) into develop (5a85e84) will increase coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #220   +/-   ##
========================================
  Coverage    87.39%   87.39%           
========================================
  Files           25       25           
  Lines         3791     3792    +1     
========================================
+ Hits          3313     3314    +1     
  Misses         478      478           
Impacted Files Coverage Δ
eodatasets3/stac.py 90.22% <75.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a85e84...64e0992. Read the comment docs.

@jeremyh jeremyh marked this pull request as ready for review November 9, 2021 23:28
Copy link
Contributor

@supermarkion supermarkion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this change

@jeremyh jeremyh merged commit fd62160 into opendatacube:develop Nov 11, 2021
@jeremyh jeremyh deleted the gridless branch November 11, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants