[RHOAIENG-11349] - Missing requirements.txt for modelmesh-runtime-adpter component #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spolti
force-pushed
the
RHOAIENG-11349
branch
2 times, most recently
from
c4ffae9
to
0d8771b
Compare
israel-hdez
reviewed
Sep 3, 2024
Jooho
reviewed
Sep 5, 2024
spolti
force-pushed
the
RHOAIENG-11349
branch
3 times, most recently
from
c8ddd76
to
5fed933
Compare
|
Moved red-hat-data-services#23 to here. |
spolti
force-pushed
the
RHOAIENG-11349
branch
from
fe970c8
to
dbf991c
Compare
|
/test images |
israel-hdez
reviewed
Sep 6, 2024
spolti
force-pushed
the
RHOAIENG-11349
branch
6 times, most recently
from
5654610
to
7367985
Compare
israel-hdez
reviewed
Sep 18, 2024
Dockerfile
Outdated
Comment on lines
172
to
178
| pip install wheel && \ | ||
| pip install grpcio && \ | ||
| # pin to 3.10.0 to avoid error: libhdf5.so: cannot open shared object file: No such file or directory \ | ||
| # if not version is set, it will install the 3.11.0 version which, seems that does not have the h5py dependencies \ | ||
| # for arm yet. | ||
| pip install h5py==3.10.0 && \ | ||
| pip install tensorflow |
There was a problem hiding this comment.
Replace all these pip install commands with a single pip install -r requirements.txt one and then I will be happy to approve.
There was a problem hiding this comment.
I agreed with @israel-hdez . However, if we replace this, we should update the requirements.txt file when the version changes.
There was a problem hiding this comment.
right, I've forget to do this, I've added the requirements file inside the container but forgot to install from it
…pter component
chore: Add the requirements.txt file and steps to generate it and correctly configure
the Konflux build.
Plus, adapt the Dockerfile to work properly witn Konflux.
Signed-off-by: Spolti <fspolti@redhat.com>
spolti
force-pushed
the
RHOAIENG-11349
branch
from
7367985
to
5b1401d
Compare
spolti
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez, spolti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@spolti will you cherry-pick to 0.12 branch? or is this only for main? |
openshift-merge-bot
bot
merged commit 7d59320
into
opendatahub-io:main
10 checks passed
|
The plan is only for main, but we can cherry-pick later. |
mholder6
pushed a commit
to mholder6/modelmesh-runtime-adapter
that referenced
this pull request
Oct 4, 2024
…pter component (opendatahub-io#65) chore: Add the requirements.txt file and steps to generate it and correctly configure the Konflux build. Plus, adapt the Dockerfile to work properly witn Konflux. Signed-off-by: Spolti <fspolti@redhat.com>
mholder6
pushed a commit
to mholder6/modelmesh-runtime-adapter
that referenced
this pull request
Oct 4, 2024
…pter component (opendatahub-io#65) chore: Add the requirements.txt file and steps to generate it and correctly configure the Konflux build. Plus, adapt the Dockerfile to work properly witn Konflux. Signed-off-by: Spolti <fspolti@redhat.com> Signed-off-by: mholder6 <marholde@redhat.com>
israel-hdez
pushed a commit
that referenced
this pull request
Oct 4, 2024
…pter component (#65) chore: Add the requirements.txt file and steps to generate it and correctly configure the Konflux build. Plus, adapt the Dockerfile to work properly witn Konflux. Signed-off-by: Spolti <fspolti@redhat.com> Signed-off-by: mholder6 <marholde@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: Adapt Dockerfile to work on Konflux.
Motivation
Modifications
Result