Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-11349] - Missing requirements.txt for modelmesh-runtime-ada… #23

Closed

Conversation

spolti
Copy link

@spolti spolti commented Sep 2, 2024

…pter component

chore: Add the requirements.txt file and steps to generate it and correctly configure
the Konflux build.

Motivation

Modifications

Result

…pter component

chore:  Add the requirements.txt file and steps to generate it and correctly configure
        the Konflux build.

Signed-off-by: Spolti <fspolti@redhat.com>
Copy link

@israel-hdez israel-hdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For ModelMesh, this may not change often.
But I wonder if there is any way to run this in Konflux, before the build? perhaps there is some intermediate repository on the build?

Otherwise, we will need to remember to update this each time dependencies change (CVE fixing would be the common source of dep updates)

@spolti
Copy link
Author

spolti commented Sep 3, 2024

@israel-hdez I believe they can configure a new step in the konflux build to do this, but, IMHO, it is still valid to keep it here as reference for future manual task.
But the version pinning is manual for now, unless we agree to hardcode these in the DOckerfile, that is from where it was taken from.
But, we can have another jira to follow-up it later when the builds would be fully migrated to konflux.

@Jooho
Copy link

Jooho commented Sep 5, 2024

The follow-up jira is to solve @israel-hdez question?

@spolti
Copy link
Author

spolti commented Sep 5, 2024

The follow-up jira is to solve @israel-hdez question?

the follow-up jira is to automate the requirements.txt generation.

@israel-hdez
Copy link

I have the idea that it is going to be much better to add the requirements.txt file in odh repository, rather than here. Even better if we can send the patch to upstream.

Also, I think we should avoid using poetry. It should be enough using pip for generating the file.

@spolti
Copy link
Author

spolti commented Sep 6, 2024

Even better if we can send the patch to upstream.

Why do you think we need it upstream?

@spolti
Copy link
Author

spolti commented Sep 6, 2024

I think we should avoid using poetry.

I did with poetry because clean requirements.txt does not allow you to set the python version range and with pip, you needed first to install everything before, then do something like this:

pip install pip-tools
pip-compile --generate-hashes -o requirements.txt

@spolti
Copy link
Author

spolti commented Sep 6, 2024

Moved to opendatahub-io#65

@spolti spolti closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants