-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-11349] - Missing requirements.txt for modelmesh-runtime-ada… #23
Conversation
…pter component chore: Add the requirements.txt file and steps to generate it and correctly configure the Konflux build. Signed-off-by: Spolti <fspolti@redhat.com>
9c32a47
to
0de2f15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For ModelMesh, this may not change often.
But I wonder if there is any way to run this in Konflux, before the build? perhaps there is some intermediate repository on the build?
Otherwise, we will need to remember to update this each time dependencies change (CVE fixing would be the common source of dep updates)
@israel-hdez I believe they can configure a new step in the konflux build to do this, but, IMHO, it is still valid to keep it here as reference for future manual task. |
The follow-up jira is to solve @israel-hdez question? |
the follow-up jira is to automate the requirements.txt generation. |
I have the idea that it is going to be much better to add the requirements.txt file in odh repository, rather than here. Even better if we can send the patch to upstream. Also, I think we should avoid using poetry. It should be enough using pip for generating the file. |
Why do you think we need it upstream? |
I did with poetry because clean requirements.txt does not allow you to set the python version range and with pip, you needed first to install everything before, then do something like this:
|
Moved to opendatahub-io#65 |
…pter component
chore: Add the requirements.txt file and steps to generate it and correctly configure
the Konflux build.
Motivation
Modifications
Result