Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish(gry): polish reward model and td error #624

Merged
merged 17 commits into from
Apr 3, 2023

Conversation

ruoyuGao
Copy link
Contributor

@ruoyuGao ruoyuGao commented Mar 28, 2023

Description

  • add the config table for each reward model
  • remove unuse parameter
  • add comment for td error

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@ruoyuGao ruoyuGao changed the title Polish(gry) : polish reward model and td error polish(gry) : polish reward model and td error Mar 28, 2023
fix style for reward model
@PaParaZz1 PaParaZz1 added the enhancement New feature or request label Mar 28, 2023
ding/reward_model/gail_irl_model.py Outdated Show resolved Hide resolved
ding/reward_model/drex_reward_model.py Outdated Show resolved Hide resolved
target_new_data_count=64,
# (int) Linear model hidden size
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why linear here, there maybe some more complicated networks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because our remodel network is linear, should we change this comment?

ding/reward_model/gail_irl_model.py Outdated Show resolved Hide resolved
ding/rl_utils/td.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #624 (d7d16ac) into main (405191d) will decrease coverage by 0.08%.
The diff coverage is 91.66%.

❗ Current head d7d16ac differs from pull request most recent head 2d741e8. Consider uploading reports for the commit 2d741e8 to get more accurate results

@@            Coverage Diff             @@
##             main     #624      +/-   ##
==========================================
- Coverage   83.03%   82.96%   -0.08%     
==========================================
  Files         570      570              
  Lines       47037    46955      -82     
==========================================
- Hits        39056    38954     -102     
- Misses       7981     8001      +20     
Flag Coverage Δ
unittests 82.96% <91.66%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/framework/task.py 93.55% <ø> (ø)
ding/policy/a2c.py 91.20% <ø> (ø)
ding/policy/acer.py 93.95% <ø> (ø)
ding/policy/atoc.py 90.90% <ø> (ø)
ding/policy/collaq.py 86.88% <ø> (ø)
ding/policy/coma.py 91.96% <ø> (ø)
ding/policy/d4pg.py 96.38% <ø> (ø)
ding/policy/ddpg.py 88.00% <ø> (ø)
ding/policy/decision_transformer.py 18.07% <ø> (ø)
ding/policy/il.py 27.77% <ø> (ø)
... and 52 more

... and 63 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PaParaZz1 PaParaZz1 merged commit a580019 into opendilab:main Apr 3, 2023
@PaParaZz1 PaParaZz1 changed the title polish(gry) : polish reward model and td error polish(gry): polish reward model and td error Apr 3, 2023
@ruoyuGao ruoyuGao deleted the ruoyugao branch April 4, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants