Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Add Master Throttling Metric #466

Conversation

dhwanilpatel
Copy link
Contributor

Description of changes:
Add Metrics for Master Throttling of Pending tasks. It will publish two metric 1) Total throttled tasks at master node 2) Number of task on which data node is actively retrying. This feature is yet to be contributed to Opensource ES. I have added the check for availability of this feature in collector so building with or without this feature will pass. If this feature is not available then collector will simply return.

PR of Performance Analyzer Plugin : opendistro-for-elasticsearch/performance-analyzer#217

Tests:

Testing

  1. /gradlew test Successful
SUCCESS: Executed 455 tests in 40m 43s (1 skipped)

BUILD SUCCESSFUL in 41m 8s
11 actionable tasks: 8 executed, 3 up-to-date
  1. Tested in test domain by replacing JAR.

Tmp file

^master_throttling_metrics
{"current_time":1602617137529}
{"Data_RetryingPendingTasksCount":0,"Master_ThrottledPendingTasksCount":0}$

Verified metric from table

sqlite> select * from Master_ThrottledPendingTasksCount;
0.0|0.0|0.0|0.0

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yojs yojs requested review from khushbr and adityaj1107 October 16, 2020 17:22
@yojs
Copy link
Contributor

yojs commented Oct 16, 2020

The CI isn't passing. There are some spot bug failures. You can rerun the spotbugs as
./gradlew spotbugsMain

And then point your browser to <project dir>/build/reports/spotbugs/main.html
That will give you an idea of what the errors are.

adityaj1107
adityaj1107 previously approved these changes Oct 19, 2020
@adityaj1107
Copy link
Contributor

There are some checkstyle errors in the CI. Fix them and merge the changes in the RCA packages first since PA depends on RCA to build (for Constants etc.).

@adityaj1107 adityaj1107 merged commit a8f7adb into opendistro-for-elasticsearch:master Oct 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants