Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Add MasterThrottlingMetric Collector #217

Conversation

dhwanilpatel
Copy link
Contributor

Description of changes:

Code change is for Master Throttling of Pending task. It will publish two metric 1) Total throttled tasks at master node 2) Number of task on which data node is actively retrying. This feature is yet to be contributed to Opensource ES. I have added the check for availability of this feature in collector so building with or without this feature will pass. If this feature is not available then collector will simply return.

Testing

  1. /gradlew test Successful
  2. Tested in test domain by replacing JAR.

Tmp file

^master_throttling_metrics
{"current_time":1602617137529}
{"Data_RetryingPendingTasksCount":0,"Master_ThrottledPendingTasksCount":0}$

Verified metric from table

sqlite> select * from Master_ThrottledPendingTasksCount;
0.0|0.0|0.0|0.0

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@yojs yojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. We just need an API to be able to turn this collector off and this should be turned off by default for the next release.

adityaj1107
adityaj1107 previously approved these changes Oct 19, 2020
@adityaj1107 adityaj1107 merged commit 72ce782 into opendistro-for-elasticsearch:master Oct 20, 2020
adityaj1107 added a commit that referenced this pull request Oct 20, 2020
adityaj1107 added a commit that referenced this pull request Oct 20, 2020
@adityaj1107
Copy link
Contributor

Merged by mistake: Merged a revert PR: #221

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants