This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 48
Add MasterThrottlingMetric Collector #217
Merged
adityaj1107
merged 4 commits into
opendistro-for-elasticsearch:master
from
dhwanilpatel:masterThrottlingMetric
Oct 20, 2020
Merged
Add MasterThrottlingMetric Collector #217
adityaj1107
merged 4 commits into
opendistro-for-elasticsearch:master
from
dhwanilpatel:masterThrottlingMetric
Oct 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yojs
reviewed
Oct 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. We just need an API to be able to turn this collector off and this should be turned off by default for the next release.
...pendistro/elasticsearch/performanceanalyzer/collectors/MasterThrottlingMetricsCollector.java
Show resolved
Hide resolved
...pendistro/elasticsearch/performanceanalyzer/collectors/MasterThrottlingMetricsCollector.java
Outdated
Show resolved
Hide resolved
...pendistro/elasticsearch/performanceanalyzer/collectors/MasterThrottlingMetricsCollector.java
Outdated
Show resolved
Hide resolved
adityaj1107
reviewed
Oct 19, 2020
...pendistro/elasticsearch/performanceanalyzer/collectors/MasterThrottlingMetricsCollector.java
Outdated
Show resolved
Hide resolved
adityaj1107
previously approved these changes
Oct 19, 2020
adityaj1107
added a commit
that referenced
this pull request
Oct 20, 2020
This reverts commit 72ce782.
adityaj1107
added a commit
that referenced
this pull request
Oct 20, 2020
Merged by mistake: Merged a revert PR: #221 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Code change is for Master Throttling of Pending task. It will publish two metric 1) Total throttled tasks at master node 2) Number of task on which data node is actively retrying. This feature is yet to be contributed to Opensource ES. I have added the check for availability of this feature in collector so building with or without this feature will pass. If this feature is not available then collector will simply return.
Testing
Tmp file
Verified metric from table
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.