fix(version): use tagged version instead of VERSION file while build #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
mittachaitu
reviewed
Jul 16, 2020
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
shubham14bajpai
force-pushed
the
version-omit
branch
from
9ac6bcf to
108c5db
Compare
shubham14bajpai
changed the title
mittachaitu
reviewed
Jul 17, 2020
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
|
|
mittachaitu
reviewed
Jul 17, 2020
shubham14bajpai
added
the
pr/hold-merge
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
mittachaitu
removed
the
pr/hold-merge
prateekpandey14
changed the title
shubham14bajpai
added a commit
to shubham14bajpai/maya
that referenced
this pull request
Jul 20, 2020
…openebs-archive#1733) - fix unstructured resource names to make it compatible with new version format - fixed runtask names and corresponding envs and castemplate to honour the version changes Signed-off-by: shubham <shubham.bajpai@mayadata.io>
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shubham shubham.bajpai@mayadata.io
What this PR does?:
This PR removes the version file dependency on the image builds. This PR modifies the build scripts to take Travis tag or the version from the VERSION file of the build. This PR also refactors some functions that relied on the version to be specifically of the type
x.y.zas the versions can differ with custom tags and RC tags. PR also comment outs some test cases based on the changes.Does this PR require any upgrade changes?:
If the changes in this PR are manually verified, list down the scenarios covered::
After building images with a custom tag 1.11.0-ce-rc2
Runtasks with custom version
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>