Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(version): use tagged version instead of VERSION file during build #1734

Merged
merged 1 commit into from
Jul 20, 2020
Merged

fix(version): use tagged version instead of VERSION file during build #1734

merged 1 commit into from
Jul 20, 2020

Conversation

shubham14bajpai
Copy link
Contributor

@shubham14bajpai shubham14bajpai commented Jul 20, 2020 •
edited
Loading

Signed-off-by: shubham shubham.bajpai@mayadata.io

What this PR does?:
This PR is cherry-pick for #1733 .

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

@shubham14bajpai
fix(version): use tagged version instead of VERSION file during build (…
b72445d 
…openebs-archive#1733)

- fix unstructured resource names to make it compatible with new version format
- fixed runtask names and corresponding envs and castemplate to honour 
   the version changes

Signed-off-by: shubham <shubham.bajpai@mayadata.io>
prateekpandey14
prateekpandey14 approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@prateekpandey14 prateekpandey14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prateekpandey14 prateekpandey14 merged commit c27cc27 into openebs-archive:v1.12.x Jul 20, 2020
@shubham14bajpai shubham14bajpai deleted the cherry-version branch October 12, 2020 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prateekpandey14 prateekpandey14 prateekpandey14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shubham14bajpai @prateekpandey14