Skip to content
This repository has been archived by the owner on May 8, 2024. It is now read-only.

templating issue in cleanup-webhook.yaml #208

Closed
al8ba opened this issue Mar 23, 2021 · 1 comment
Closed

templating issue in cleanup-webhook.yaml #208

al8ba opened this issue Mar 23, 2021 · 1 comment
Assignees

Comments

@al8ba
Copy link

al8ba commented Mar 23, 2021

The new cleanup-webhook.yaml has an issue when deploying the chart with a .Values.webhook.tolerations defined. The chart uses the tolerations via:

  {{- if .Values.webhook.tolerations }}
  tolerations:
  {{ toYaml .Values.webhook.tolerations | indent 8 }}
  {{- end }}

When rendered, this indents the tolerations incorrectly due to the spaces at the start of the 'toYaml' line (see deployment-admission-server.yaml for how this should be used).

However, that said, does this actually need to pull in tolerations? This is a template for a Job, it does not have a nodeSelector that may need accompanying tolerations - I suspect the four lines above could just be removed.

@kmova
Copy link
Member

kmova commented Jun 16, 2021

Fixed by #224

@kmova kmova closed this as completed Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants