Skip to content
This repository has been archived by the owner on May 8, 2024. It is now read-only.

[stable/openebs]: update helm chart to 2.10.0 #224

Merged
merged 6 commits into from
Jun 16, 2021

Conversation

akhilerm
Copy link
Contributor

@akhilerm akhilerm commented Jun 11, 2021

  • update chart version
  • update values
  • update README
  • update dependency charts
  • fix indentation in webhook cleanup template

Signed-off-by: Akhil Mohan akhil.mohan@mayadata.io

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/openebs])

- update chart version
- update values
- update README

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@akhilerm akhilerm added the pr/hold-merge The PR should not be merged now label Jun 11, 2021
Copy link
Contributor

@shovanmaity shovanmaity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want to send another pr to update dependency chart version?

@akhilerm
Copy link
Contributor Author

do you want to send another pr to update dependency chart version?

Nope, Will do it in the same PR. Thought I will update it only once the charts are available.

Also e2e uses the helm chart from this PR during helm update testing. cc: @nsathyaseelan

akhilerm added 3 commits June 11, 2021 23:17
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@akhilerm
Copy link
Contributor Author

@shovanmaity Updated the dependency charts in the PR.

@shovanmaity
Copy link
Contributor

Hi @akhilerm can you please include this patch in this PR?

0001-fix-helm-chart-fix-indentation-issue-for-webhook-cle.txt

ref -
#225 (comment)
#225 (comment)

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@akhilerm
Copy link
Contributor Author

Done @shovanmaity

@shovanmaity
Copy link
Contributor

Done @shovanmaity

Thank you!

Copy link
Contributor

@shovanmaity shovanmaity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@akhilerm akhilerm removed the pr/hold-merge The PR should not be merged now label Jun 16, 2021
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Copy link
Contributor

@prateekpandey14 prateekpandey14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@kmova kmova merged commit 057a936 into openebs:master Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants