This repository has been archived by the owner on May 8, 2024. It is now read-only.
fix(helm-chart): fix indentation issue for webhook cleanup job #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove tolerations for cleanup job as we don't need it. This will fix the tolerations issue for webhook cleanup job. Signed-off-by: Shovan Maity <shovan.cse91@gmail.com>
kmova
reviewed
Jun 15, 2021
| @@ -23,10 +23,6 @@ spec: | |||
| app: {{ template "openebs.name" . }} | |||
| spec: | |||
| serviceAccountName: {{ template "openebs.serviceAccountName" . }} | |||
| {{- if .Values.webhook.tolerations }} | |||
There was a problem hiding this comment.
@shovanmaity - let us fix the indentation issue and keep the tolerations. In some setups, every node is tainted like in openshift and would need admin to provide a toleration for job or pod to run.
There was a problem hiding this comment.
Also, can this fix be taken into the 2.10 helm chart.
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix - #208
Remove toleration for cleanup job as we don't need it. This will fix the tolerations issue for webhook cleanup job.