Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(version): fix castemplate output runstask version suffix #1735

Merged
merged 1 commit into from
Jul 21, 2020
Merged

fix(version): fix castemplate output runstask version suffix #1735

merged 1 commit into from
Jul 21, 2020

Conversation

shubham14bajpai
Copy link
Contributor

@shubham14bajpai shubham14bajpai commented Jul 21, 2020 •
edited by prateekpandey14
Loading

Signed-off-by: shubham shubham.bajpai@mayadata.io

What this PR does?:
PR fixes the issue with output runtask version suffix ( RC1 --> rc1) . (Changes got missed to commit earlier due to some local rebase errors and got stashed locally)

more info #1733

Response Code from ApiServer: 500
Retrying.... 31
Logs of api-server: 
  labels:
    castName: jiva-volume-list-default-1.12.0-ee-rc1
    kubeVersion: v1.13.0
    version: 1.12.0-ee-RC1
  name: jiva-volume-list-default-1.12.0-ee-rc1
  resourceVersion: "1633"
  selfLink: /apis/openebs.io/v1alpha1/castemplates/jiva-volume-list-default-1.12.0-ee-rc1
  uid: 47c9f62e-cab7-11ea-8dde-42010a1e017c
spec:
  defaultConfig: null
  fallback: ""
  output: jiva-volume-list-output-default-1.12.0-ee-RC1
  run:
    tasks:
    - jiva-volume-list-listtargetservice-default-1.12.0-ee-rc1
    - jiva-volume-list-listtargetpod-default-1.12.0-ee-rc1
    - jiva-volume-list-listreplicapod-default-1.12.0-ee-rc1
    - jiva-volume-list-listpv-default-1.12.0-ee-rc1
  taskNamespace: openebs
}: exhausted all strategies to get runtask: failed to get runtask 'jiva-volume-list-output-default-1.12.0-ee-RC1'

Does this PR require any upgrade changes?:

If the changes in this PR are manually verified, list down the scenarios covered::

After building images with a custom tag 1.11.0-ee-rc2

output: cstor-volume-create-output-default-1.12.0-ee-rc1
  run:
    tasks:
    - cstor-volume-create-getstorageclass-default-1.12.0-ee-rc1
    - cstor-volume-create-getpvc-default-1.12.0-ee-rc1
    - cstor-volume-create-listclonecstorvolumereplicacr-default-1.12.0-ee-rc1
    - cstor-volume-create-listcstorpoolcr-default-1.12.0-ee-rc1
    - cstor-volume-create-puttargetservice-default-1.12.0-ee-rc1
    - cstor-volume-create-putcstorvolumecr-default-1.12.0-ee-rc1
    - cstor-volume-create-puttargetdeployment-default-1.12.0-ee-rc1
    - cstor-volume-create-putcstorvolumereplicacr-default-1.12.0-ee-rc1
  taskNamespace: openebs

Steps Performed

  • Provisioned cstor SPC
  • Provisioned cstor volume
  • Provisioned jiva volume
  • Snapshot Jiva volume
  • Deleted jiva volume
  • Deleted cstor volume
  • Deleted cstor SPC
  • Deleted runtasks and restarted api-server, all the runtasks came back with correct version.
  • Tested upgrade from 1.10.0
  • Runtasks with custom version

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

@shubham14bajpai
fix(version): fix castemplate output runstask names
7371367 
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
@shubham14bajpai shubham14bajpai mentioned this pull request Jul 21, 2020
Merged
7 tasks
@AmitKumarDas AmitKumarDas merged commit c77ea7f into openebs-archive:master Jul 21, 2020
mittachaitu pushed a commit to mittachaitu/maya that referenced this pull request Aug 11, 2020
fix(volume provisioning): fix CStor volume creation without PVC
552f019 
This PR fixes CStor volume provisioning issue. Currently
REST request to create CStor volume will fail if request
is made without creating PVC because of following bug:
- When the REST API is called to create volume it will
  verify whether request payload has PVC name. If PVC
  name doesn't exist then it will skip execution of
  `cstor-volume-create-puttargetservice-default` runtask
  but with latest changes of PR [1735](openebs-archive#1735)
   above runtask is not skiped and leads to failure in creation
  of CStor volume.

Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
@mittachaitu mittachaitu mentioned this pull request Aug 11, 2020
Merged
7 tasks
kmova pushed a commit that referenced this pull request Aug 11, 2020
@kmova
fix(volume provisioning): fix CStor volume creation without PVC
666572c 
This PR fixes CStor volume provisioning issue. Currently
REST request to create CStor volume will fail if request
is made without creating PVC because of following bug:
- When the REST API is called to create volume it will
  verify whether request payload has PVC name. If PVC
  name doesn't exist then it will skip execution of
  `cstor-volume-create-puttargetservice-default` runtask
  but with latest changes of PR [1735](#1735)
   above runtask is not skiped and leads to failure in creation
  of CStor volume.

Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
mittachaitu pushed a commit to mittachaitu/maya that referenced this pull request Aug 11, 2020
fix(volume provisioning): fix CStor volume creation without PVC
e452a0b 
This PR fixes CStor volume provisioning issue. Currently
REST request to create CStor volume will fail if request
is made without creating PVC because of following bug:
- When the REST API is called to create volume it will
  verify whether request payload has PVC name. If PVC
  name doesn't exist then it will skip execution of
  `cstor-volume-create-puttargetservice-default` runtask
  but with latest changes of PR [1735](openebs-archive#1735)
   above runtask is not skiped and leads to failure in creation
  of CStor volume.

Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
mittachaitu pushed a commit to mittachaitu/maya that referenced this pull request Aug 11, 2020
fix(volume provisioning): fix CStor volume creation without PVC
30647ce 
This PR fixes CStor volume provisioning issue. Currently
REST request to create CStor volume will fail if request
is made without creating PVC because of following bug:
- When the REST API is called to create volume it will
  verify whether request payload has PVC name. If PVC
  name doesn't exist then it will skip execution of
  `cstor-volume-create-puttargetservice-default` runtask
  but with latest changes of PR [1735](openebs-archive#1735)
   above runtask is not skiped and leads to failure in creation
  of CStor volume.

Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
kmova pushed a commit that referenced this pull request Aug 11, 2020
@kmova
fix(volume provisioning): fix CStor volume creation without PVC
57573c4 
This PR fixes CStor volume provisioning issue. Currently
REST request to create CStor volume will fail if request
is made without creating PVC because of following bug:
- When the REST API is called to create volume it will
  verify whether request payload has PVC name. If PVC
  name doesn't exist then it will skip execution of
  `cstor-volume-create-puttargetservice-default` runtask
  but with latest changes of PR [1735](#1735)
   above runtask is not skiped and leads to failure in creation
  of CStor volume.

Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
kmova pushed a commit that referenced this pull request Aug 11, 2020
@kmova
fix(volume provisioning): fix CStor volume creation without PVC
5fef9c5 
This PR fixes CStor volume provisioning issue. Currently
REST request to create CStor volume will fail if request
is made without creating PVC because of following bug:
- When the REST API is called to create volume it will
  verify whether request payload has PVC name. If PVC
  name doesn't exist then it will skip execution of
  `cstor-volume-create-puttargetservice-default` runtask
  but with latest changes of PR [1735](#1735)
   above runtask is not skiped and leads to failure in creation
  of CStor volume.

Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
@shubham14bajpai shubham14bajpai deleted the fix-version branch October 12, 2020 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmitKumarDas AmitKumarDas AmitKumarDas approved these changes

@prateekpandey14 prateekpandey14 Awaiting requested review from prateekpandey14

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shubham14bajpai @AmitKumarDas