Skip to content

Commit

Permalink
fix(mount): creating directory with 0755 permission (#262)
Browse files Browse the repository at this point in the history

Signed-off-by: Pawan <pawan@mayadata.io>
  • Loading branch information
pawanpraka1 authored Dec 23, 2020
1 parent 0e30989 commit 2e5e61d
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions pkg/zfs/mount.go
Original file line number Diff line number Diff line change
Expand Up @@ -254,16 +254,12 @@ func MountDataset(vol *apis.ZFSVolume, mount *MountInfo) error {

// MountFilesystem mounts the disk to the specified path
func MountFilesystem(vol *apis.ZFSVolume, mount *MountInfo) error {
if err := os.MkdirAll(mount.MountPath, 0000); err != nil {
// creating the directory with 0755 permission so that it can be accessed by other person.
// if the directory already exist(old k8s), the creator should set the proper permission.
if err := os.MkdirAll(mount.MountPath, 0755); err != nil {
return status.Errorf(codes.Internal, "Could not create dir {%q}, err: %v", mount.MountPath, err)
}

// in case if the dir already exists, above call returns nil
// so permission needs to be updated
if err := os.Chmod(mount.MountPath, 0000); err != nil {
return status.Errorf(codes.Internal, "Could not change mode of dir {%q}, err: %v", mount.MountPath, err)
}

switch vol.Spec.VolumeType {
case VolTypeDataset:
return MountDataset(vol, mount)
Expand Down

0 comments on commit 2e5e61d

Please sign in to comment.