fix(mount): creating directory with 0755 permission #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
=========================================
- Coverage 7.70% 1.11% -6.60%
=========================================
Files 20 11 -9
Lines 1155 899 -256
=========================================
- Hits 89 10 -79
+ Misses 1065 889 -176
+ Partials 1 0 -1 Continue to review full report at Codecov.
|
Signed-off-by: Pawan <pawan@mayadata.io>
kmova
reviewed
Dec 19, 2020
| @@ -254,16 +254,10 @@ func MountDataset(vol *apis.ZFSVolume, mount *MountInfo) error { | |||
|
|
|||
| // MountFilesystem mounts the disk to the specified path | |||
| func MountFilesystem(vol *apis.ZFSVolume, mount *MountInfo) error { | |||
| if err := os.MkdirAll(mount.MountPath, 0000); err != nil { | |||
| if err := os.MkdirAll(mount.MountPath, 0755); err != nil { | |||
There was a problem hiding this comment.
n_: can we add a comment on why 0755 is being used as the default permissions?
There was a problem hiding this comment.
added the comment @kmova
Signed-off-by: Pawan <pawan@mayadata.io>
kmova
approved these changes
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pawan pawan@mayadata.io