fix(zfspv): rounding off the volume size to Gi and Mi #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanpraka1
changed the title
pawanpraka1
force-pushed
the
roundoff
branch
2 times, most recently
from
d7c1cf5
to
18cc7c0
Compare
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
==========================================
- Coverage 22.88% 9.88% -13.00%
==========================================
Files 14 20 +6
Lines 485 1163 +678
==========================================
+ Hits 111 115 +4
- Misses 373 1047 +674
Partials 1 1
Continue to review full report at Codecov.
|
pawanpraka1
force-pushed
the
roundoff
branch
7 times, most recently
from
11a6366
to
479fe46
Compare
ZFS does not create the zvol if volume size is not multiple of the volblocksize. There are use cases where customer will create a PVC with size as 5G, which will be 5 * 1000 * 1000 * 1000 bytes and this is not the multiple of default volblocksize 8k. In ZFS, volblocksize and recordsize must be power of 2 from 512B to 1M, so keeping the size in the form of Gi or Mi should be sufficient to make volsize multiple of volblocksize/recordsize. Signed-off-by: Pawan <pawan@mayadata.io>
kmova
reviewed
Aug 7, 2020
Signed-off-by: Pawan <pawan@mayadata.io>
kmova
approved these changes
Aug 7, 2020
pawanpraka1
added a commit
to pawanpraka1/zfs-localpv
that referenced
this pull request
Aug 10, 2020
ZFS does not create the zvol if volume size is not multiple of the volblocksize. There are use cases where customer will create a PVC with size as 5G, which will be 5 * 1000 * 1000 * 1000 bytes and this is not the multiple of default volblocksize 8k. In ZFS, volblocksize and recordsize must be power of 2 from 512B to 1M, so keeping the size in the form of Gi or Mi should be sufficient to make volsize multiple of volblocksize/recordsize. Signed-off-by: Pawan <pawan@mayadata.io>
kmova
pushed a commit
that referenced
this pull request
Aug 10, 2020
ZFS does not create the zvol if volume size is not multiple of the volblocksize. There are use cases where customer will create a PVC with size as 5G, which will be 5 * 1000 * 1000 * 1000 bytes and this is not the multiple of default volblocksize 8k. In ZFS, volblocksize and recordsize must be power of 2 from 512B to 1M, so keeping the size in the form of Gi or Mi should be sufficient to make volsize multiple of volblocksize/recordsize. Signed-off-by: Pawan <pawan@mayadata.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #188
Signed-off-by: Pawan pawan@mayadata.io
Why is this PR required? What issue does it fix?:
ZFS does not create the zvol if volume size is not multiple of
the volblocksize. There are use cases where customer will create
a PVC with size as 5G, which will be 5 * 1000 * 1000 * 1000 bytes
and this is not the multiple of default volblocksize 8k.
What this PR does?:
In ZFS, volblocksize and recordsize must be power of 2 from 512B to 1M,
so keeping the size in the form of Gi or Mi should be
sufficient to make volsize multiple of volblocksize/recordsize.
Checklist:
<type>(<scope>): <subject>