Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/zfs-localpv]: update charts to 1.5.0 #296

Merged
merged 2 commits into from
Mar 16, 2021

Conversation

shubham14bajpai
Copy link
Member

Signed-off-by: shubham shubham.bajpai@mayadata.io

What this PR does?:
- update chart version
- update README
- update values.yaml

Does this PR require any upgrade changes?:
No

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

    - update chart version
    - update README
    - update values.yaml

Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Copy link
Member

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubham14bajpai There were some changes to the zfs restore crd. Ref: https://github.com/openebs/zfs-localpv/pull/292/files#diff-f7969bf1fb338e0967953c18f35f397634cd87936801e38d4c81654225f9524c

This needs to be updated in the deploy/helm/charts/crds

Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Copy link
Member

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pawanpraka1 pawanpraka1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@pawanpraka1 pawanpraka1 merged commit 3162112 into openebs:master Mar 16, 2021
@pawanpraka1 pawanpraka1 added this to the v1.5.0 milestone Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants