fix(plugin): Fix ability to have custom value for openebs.io/nodeid #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnels124
force-pushed
the
node-id-fix
branch
2 times, most recently
from
9ff5475
to
c854109
Compare
|
@niladrih when you have a moment would you mind taking a peak at this PR. It is a critical fix in order for our deployment. Without this change, we will not be able to perform node upgrades within the cluster. |
There was a problem hiding this comment.
Should have some tests for the changes to both go classes
|
@jnels124 Can you please rebase your code. Also please add the testing steps in the Documentation file as part of this PR. |
|
@hrudaya21 I have rebased and updated install documentation to reference existing documentation. Please let me know if anything else is needed to get this merged. |
sinhaashish
force-pushed
the
node-id-fix
branch
from
153a256
to
318214c
Compare
|
See #489. Might still be broken. |
Signed-off-by: Jesse Nelson <jesse@swirldslabs.com>
Signed-off-by: Jesse Nelson <jesse@swirldslabs.com>
Signed-off-by: Jesse Nelson <jesse@swirldslabs.com>
Signed-off-by: Jesse Nelson <jesse@swirldslabs.com>
Signed-off-by: Jesse Nelson <jesse@swirldslabs.com>
Signed-off-by: Jesse Nelson <jesse@swirldslabs.com>
Signed-off-by: Jesse Nelson <jesse@swirldslabs.com>
hrudaya21
force-pushed
the
node-id-fix
branch
from
318214c
to
1058228
Compare
hrudaya21
approved these changes
Nov 29, 2023
sinhaashish
approved these changes
Dec 20, 2023
This was referenced Dec 20, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request template
Please, go through these steps before you submit a PR.
Why is this PR required? What issue does it fix?:
This PR is required in order to allow a ZFS volume to be moved to another node
What this PR does?:
This pr fixes existing logic that attempts to retrieve a node using the name and instead retrieves the node using the nodeid label
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
These changes were manually verified by doing the following:
kubectl label node <Node> openebs.io/nodeid=value-1Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>