feat(validation): adding validation for ZFSPV CR parameters #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
=======================================
Coverage 23.57% 23.57%
=======================================
Files 14 14
Lines 475 475
=======================================
Hits 112 112
Misses 362 362
Partials 1 1 Continue to review full report at Codecov.
|
pawanpraka1
force-pushed
the
crd
branch
2 times, most recently
from
072f247
to
7afd210
Compare
akhilerm
reviewed
Mar 27, 2020
|
@pawanpraka1 -- any validations required for the ZFS Snapshot CRD? |
no @kmova, user will modify ZFSVolume CR only for the property change. |
|
Makes sense. on second thought, does adding validations for non-editable fields help in making sure the code also doesn't misbehave, can work as an added validation as the contributions to the project increase? |
sonasingh46
approved these changes
Mar 28, 2020
|
Sure, I will add the validation for snapshot also. |
pawanpraka1
force-pushed
the
crd
branch
3 times, most recently
from
3b95381
to
d7a135c
Compare
pawanpraka1
force-pushed
the
crd
branch
2 times, most recently
from
bd79287
to
7404088
Compare
Validating few parameters for the ZFSVolume custom resource - compression can be "on", "off", "lzjb", "gzip", "gzip-[1-9]", "zle" and "lz4" - encryption can be "on", "off", "aes-128-ccm", "aes-192-ccm", "aes-256-ccm", "aes-128-gcm", "aes-192-gcm", and "aes-256-gcm" - dedup can be "on" and "off" - poolname can be string - ownernodeid can be string - thinprovision can be "yes" and "no" - volumetype can be "DATASET" and "ZVOL" Also added required fields needed to create ZFSVolume CR - ownerNodeID - poolname - volumeType - capacity Signed-off-by: Pawan <pawan@mayadata.io>
Signed-off-by: Pawan <pawan@mayadata.io>
Signed-off-by: Pawan <pawan@mayadata.io>
kmova
reviewed
Apr 4, 2020
kmova
reviewed
Apr 4, 2020
kmova
reviewed
Apr 4, 2020
kmova
reviewed
Apr 4, 2020
kmova
reviewed
Apr 4, 2020
kmova
reviewed
Apr 4, 2020
kmova
reviewed
Apr 4, 2020
kmova
reviewed
Apr 4, 2020
pawanpraka1
force-pushed
the
crd
branch
2 times, most recently
from
be1a639
to
994c7a3
Compare
Signed-off-by: Pawan <pawan@mayadata.io>
kmova
reviewed
Apr 14, 2020
pawanpraka1
force-pushed
the
crd
branch
3 times, most recently
from
ddbb9b6
to
1e98277
Compare
Signed-off-by: Pawan <pawan@mayadata.io>
kmova
approved these changes
Apr 14, 2020
pawanpraka1
added a commit
to pawanpraka1/zfs-localpv
that referenced
this pull request
Apr 14, 2020
Validating few parameters for the ZFSVolume custom resource - compression can be "on", "off", "lzjb", "gzip", "gzip-[1-9]", "zle" and "lz4" - encryption can be "on", "off", "aes-128-ccm", "aes-192-ccm", "aes-256-ccm", "aes-128-gcm", "aes-192-gcm", and "aes-256-gcm" - dedup can be "on" and "off" - poolname can be string - ownernodeid can be string - thinprovision can be "yes" and "no" - volumetype can be "DATASET" and "ZVOL" Also added required fields needed to create ZFSVolume CR - ownerNodeID - poolname - volumeType - capacity Signed-off-by: Pawan <pawan@mayadata.io>
Merged
kmova
pushed a commit
that referenced
this pull request
Apr 14, 2020
Validating few parameters for the ZFSVolume custom resource - compression can be "on", "off", "lzjb", "gzip", "gzip-[1-9]", "zle" and "lz4" - encryption can be "on", "off", "aes-128-ccm", "aes-192-ccm", "aes-256-ccm", "aes-128-gcm", "aes-192-gcm", and "aes-256-gcm" - dedup can be "on" and "off" - poolname can be string - ownernodeid can be string - thinprovision can be "yes" and "no" - volumetype can be "DATASET" and "ZVOL" Also added required fields needed to create ZFSVolume CR - ownerNodeID - poolname - volumeType - capacity Signed-off-by: Pawan <pawan@mayadata.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validating few parameters for the ZFSVolume custom resource
Also added required fields needed to create ZFSVolume CR
For the below wrong yaml
Applying it will throw this error
$ kubectl apply -f zfspvcr.yaml
The ZFSVolume "pvc-test" is invalid: spec.compression: Invalid value: "": spec.compression in body should match '^(on|off|lzjb|gzip|gzip-[1-9]|zle|lz4)$'
Signed-off-by: Pawan pawan@mayadata.io